Skip to content

Conversation

@thisisnic
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

@thisisnic
Copy link
Member Author

@github-actions crossbow submit all

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

Unable to match any tasks for `all`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/1549029093```

@thisisnic
Copy link
Member Author

@github-actions crossbow -g r

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

No such option: -g
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/1549034406```

@thisisnic
Copy link
Member Author

@github-actions crossbow submit -g r

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

Revision: 1938ed9

Submitted crossbow builds: ursacomputing/crossbow @ actions-1256

Task Status
conda-linux-gcc-py36-cpu-r40 Azure
conda-linux-gcc-py37-cpu-r41 Azure
conda-osx-clang-py36-r40 Azure
conda-osx-clang-py37-r41 Azure
conda-win-vs2017-py36-r40 Azure
conda-win-vs2017-py37-r41 Azure
homebrew-r-autobrew Github Actions
test-fedora-r-clang-sanitizer Azure
test-r-arrow-backwards-compatibility Github Actions
test-r-depsource-bundled Azure
test-r-depsource-system Github Actions
test-r-devdocs Github Actions
test-r-gcc-11 Github Actions
test-r-install-local Github Actions
test-r-linux-as-cran Github Actions
test-r-linux-rchk Github Actions
test-r-linux-valgrind Azure
test-r-minimal-build Azure
test-r-offline-maximal Github Actions
test-r-offline-minimal Azure
test-r-rhub-debian-gcc-devel-lto-latest Azure
test-r-rhub-ubuntu-gcc-release-latest Azure
test-r-rocker-r-base-latest Azure
test-r-rstudio-r-base-4.1-centos7-devtoolset-8 Azure
test-r-rstudio-r-base-4.1-centos8 Azure
test-r-rstudio-r-base-4.1-focal Azure
test-r-rstudio-r-base-4.1-opensuse15 Azure
test-r-rstudio-r-base-4.1-opensuse42 Azure
test-r-ubuntu-21.04 Github Actions
test-r-versions Github Actions
test-ubuntu-18.04-r-sanitizer Azure

Copy link
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other thing we should do, if you haven't already, is document how to install all of the possible dependencies with system packages, which ones can't be installed as system packages, etc. This may be general C++ documentation, but we may also want an R-flavored version since we don't deal with all of the possible C++ dependencies in the R package (some are for features we don't enable, some are test/dev dependencies, etc.). Maybe the docs just start by pointing at ci/docker and all of the cpp docker files there: they install dependencies, set ARROW_DEPENDENCY_SOURCE=SYSTEM, and then also set a few other dependency sources as BUNDLED. Some dockerfiles even have comments explaining why (insufficient version, etc.).

if [ "${ARROW_DEPENDENCY_SOURCE}" = "" ]; then
# TODO: BUNDLED is still default for now, but we plan to change it to AUTO
ARROW_DEPENDENCY_SOURCE=BUNDLED; export ARROW_DEPENDENCY_SOURCE
ARROW_DEPENDENCY_SOURCE=AUTO; export ARROW_DEPENDENCY_SOURCE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Can't leave this comment below but) on L162, we should revise the message, maybe just

echo "**** pkg-config not installed, setting ARROW_DEPENDENCY_SOURCE=BUNDLED"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@thisisnic
Copy link
Member Author

The other thing we should do, if you haven't already, is document how to install all of the possible dependencies with system packages, which ones can't be installed as system packages, etc. This may be general C++ documentation, but we may also want an R-flavored version since we don't deal with all of the possible C++ dependencies in the R package (some are for features we don't enable, some are test/dev dependencies, etc.). Maybe the docs just start by pointing at ci/docker and all of the cpp docker files there: they install dependencies, set ARROW_DEPENDENCY_SOURCE=SYSTEM, and then also set a few other dependency sources as BUNDLED. Some dockerfiles even have comments explaining why (insufficient version, etc.).

OK, will be sure to cover this in #11521

Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good (and will be especially good to check this in CI for a bit before the release).

I've looked through the build logs and both the bundled and system ones seems to be doing what we expect.

@thisisnic thisisnic closed this in 04ed72d Dec 8, 2021
@ursabot
Copy link

ursabot commented Dec 8, 2021

Benchmark runs are scheduled for baseline = 392a25f and contender = 04ed72d. 04ed72d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️3.7% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.04% ⬆️0.09%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants