Skip to content

MINOR: [C++] Add missing docstrings for ChunkedArray methods #11902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Jedi18 wants to merge 1 commit into from
Closed

MINOR: [C++] Add missing docstrings for ChunkedArray methods #11902

Jedi18 wants to merge 1 commit into from

Conversation

@Jedi18
Copy link
Contributor

@Jedi18 Jedi18 commented Dec 8, 2021 •
edited by pitrou
Loading

Add a few missing docstrings for public ChunkedArray methods.

@pitrou pitrou changed the title MINOR: [C++] Add minor missing comments for chunked_array MINOR: [C++] Add missing docstrings for ChunkedArray methods Dec 8, 2021
pitrou
pitrou approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Jedi18 . I polished the PR title and descriptions but this looks good to me otherwise.

@pitrou
Copy link
Member

pitrou commented Dec 8, 2021

Note the Gandiva compilation failures on CI are unrelated (see #11905).

@pitrou pitrou closed this in a005d79 Dec 8, 2021
@ursabot
Copy link

ursabot commented Dec 8, 2021 •
edited
Loading

Benchmark runs are scheduled for baseline = 9ed9e60 and contender = a005d79. a005d79 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] ursa-i9-9960x
[Finished ⬇️0.31% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jedi18 @pitrou @ursabot