ARROW-13401 [R]: Update python.Rmd vignette #11914
Conversation
thisisnic
left a comment
thisisnic
left a comment
There was a problem hiding this comment.
This is looking good! Most of the changes I've suggested are stylistic things we updated across the other R documentation which I forgot to mention in this ticket. Your explanations of things here look great - thanks for adding in those bits!
Co-authored-by: Nic Crane <thisisnic@gmail.com>
thisisnic
left a comment
thisisnic
left a comment
There was a problem hiding this comment.
One tiny additional change, otherwise it's good to go
Co-authored-by: Nic Crane <thisisnic@gmail.com>
|
Info: committed the changes for this PR completely through the GitHub editor! |
Thanks for mentioning! I guess the thing I'd recommend is doing it locally to build the docs to make sure they look OK, but for this PR I'm happy to double check that myself :) |
Co-authored-by: Nic Crane <thisisnic@gmail.com>
|
Benchmark runs are scheduled for baseline = b74d8cf and contender = fa5bbb7. fa5bbb7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
3 participants
No description provided.