Skip to content

ARROW-15096: [R] Sanitizer failures with duration type #11947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
paleolimbot wants to merge 3 commits into from
Closed

ARROW-15096: [R] Sanitizer failures with duration type #11947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e38813
maybe fix sanitizer error on duration type
paleolimbot Dec 14, 2021
f494d89
fix another reference to TimeType that should have been DurationType
paleolimbot Dec 14, 2021
8a5faa6
fix clang-format linter
paleolimbot Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion r/src/array_to_vector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,7 +886,7 @@ class Converter_Time : public Converter {
}
};

template <typename value_type, typename unit_type = TimeType>
template <typename value_type, typename unit_type = DurationType>
class Converter_Duration : public Converter {
public:
explicit Converter_Duration(const std::shared_ptr<ChunkedArray>& chunked_array)
Expand Down
4 changes: 2 additions & 2 deletions r/src/arrowExports.cpp
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion r/src/datatype.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,8 @@ arrow::TimeUnit::type TimeType__unit(const std::shared_ptr<arrow::TimeType>& typ
}

// [[arrow::export]]
arrow::TimeUnit::type DurationType__unit(const std::shared_ptr<arrow::TimeType>& type) {
arrow::TimeUnit::type DurationType__unit(
const std::shared_ptr<arrow::DurationType>& type) {
return type->unit();
}

Expand Down