Skip to content

ARROW-15101: [Python] Fix build failure on CSV writer #11950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pitrou wants to merge 2 commits into from
Closed

ARROW-15101: [Python] Fix build failure on CSV writer #11950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c7d11d
ARROW-15101: [Python] Fix build failure on CSV writer
pitrou Dec 14, 2021
97a9a4f
Make sure arrow/util/config.h is included where needed.
pitrou Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cpp/src/arrow/csv/api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
#include "arrow/csv/reader.h"

// The writer depends on compute module for casting.
#include "arrow/util/config.h" // for ARROW_COMPUTE definition
#ifdef ARROW_COMPUTE
#include "arrow/csv/writer.h"
#endif
1 change: 1 addition & 0 deletions cpp/src/arrow/util/basic_decimal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
#include <string>

#include "arrow/util/bit_util.h"
#include "arrow/util/config.h" // for ARROW_USE_NATIVE_INT128
#include "arrow/util/endian.h"
#include "arrow/util/int128_internal.h"
#include "arrow/util/int_util_internal.h"
Expand Down
4 changes: 0 additions & 4 deletions cpp/src/parquet/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,3 @@ endif()
if(ARROW_WITH_ZSTD)
add_definitions(-DARROW_WITH_ZSTD)
endif()

if(ARROW_CSV)
add_definitions(-DARROW_CSV)
endif()
1 change: 1 addition & 0 deletions cpp/src/parquet/arrow/arrow_reader_writer_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
#include "arrow/testing/util.h"
#include "arrow/type_traits.h"
#include "arrow/util/checked_cast.h"
#include "arrow/util/config.h" // for ARROW_CSV definition
#include "arrow/util/decimal.h"
#include "arrow/util/future.h"
#include "arrow/util/logging.h"
Expand Down