Skip to content

ARROW-15119: [C++] allow reading directories as files in generic tests #11962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
coryan wants to merge 1 commit into from
Closed

ARROW-15119: [C++] allow reading directories as files in generic tests #11962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cpp/src/arrow/filesystem/test_util.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -961,7 +961,9 @@ void GenericFileSystemTest::TestOpenInputStream(FileSystem* fs) {
ASSERT_RAISES(IOError, fs->OpenInputStream("def"));

// Cannot open directory
ASSERT_RAISES(IOError, fs->OpenInputStream("AB"));
if (!allow_read_dir_as_file()) {
ASSERT_RAISES(IOError, fs->OpenInputStream("AB"));
}
}

void GenericFileSystemTest::TestOpenInputStreamWithFileInfo(FileSystem* fs) {
Expand Down Expand Up @@ -1029,7 +1031,9 @@ void GenericFileSystemTest::TestOpenInputFile(FileSystem* fs) {
ASSERT_RAISES(IOError, fs->OpenInputFile("def"));

// Cannot open directory
ASSERT_RAISES(IOError, fs->OpenInputFile("AB"));
if (!allow_read_dir_as_file()) {
ASSERT_RAISES(IOError, fs->OpenInputFile("AB"));
}
}

void GenericFileSystemTest::TestOpenInputFileAsync(FileSystem* fs) {
Expand Down
2 changes: 2 additions & 0 deletions cpp/src/arrow/filesystem/test_util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,8 @@ class ARROW_TESTING_EXPORT GenericFileSystemTest {
virtual bool have_implicit_directories() const { return false; }
// - Whether the filesystem may allow writing a file "over" a directory
virtual bool allow_write_file_over_dir() const { return false; }
// - Whether the filesystem allows reading a directory
virtual bool allow_read_dir_as_file() const { return false; }
// - Whether the filesystem allows moving a directory
virtual bool allow_move_dir() const { return true; }
// - Whether the filesystem allows moving a directory "over" a non-empty destination
Expand Down