ARROW-15040: [R] Enable write_csv_arrow to take a Dataset or arrow_dplyr_query as input #11971
Conversation
|
|
jonkeane
left a comment
jonkeane
left a comment
There was a problem hiding this comment.
Oh, this is exciting! One comment about types. It also looks like there are some(?) related segfaults in the CI
|
It may be worth rebasing this and seeing if it still segfaults! I know there were some updates to the Scanner that fixed some segfaults for me when I was writing tests for the Python bridge (from the Python side). Another way to write this test that would be independent of that is to Scan a I'm also a fan of the "allow a general record batch reader" approach, which might also make this easier to test. |
|
Also linking ARROW-15128 since it seems like a blocker for this PR. |
thisisnic
force-pushed
the
ARROW-15040_rb_reader
branch
from
b45f9e6 to
43f08f3
Compare
|
Thanks for the suggestion @paleolimbot but the segfault is still happening after a rebase. |
thisisnic
force-pushed
the
ARROW-15040_rb_reader
branch
from
ff62a45 to
01e1ae5
Compare
|
Have now updated this and removed the blocker ticket which isn't a blocker! |
thisisnic
changed the title
nealrichardson
left a comment
nealrichardson
left a comment
There was a problem hiding this comment.
Should also write a test for accepting RecordBatchReader, and need to update the docs too
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
nealrichardson
left a comment
nealrichardson
left a comment
There was a problem hiding this comment.
A couple of final suggestions
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
|
Benchmark runs are scheduled for baseline = 676b49f and contender = 13045f4. 13045f4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
5 participants
No description provided.