Skip to content

ARROW-1673: [Python] Add support for numpy 'bool' type #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pcmoritz wants to merge 4 commits into from
Closed

ARROW-1673: [Python] Add support for numpy 'bool' type #1199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
11c7ed3
add support for numpy 'bool' type
pcmoritz Oct 13, 2017
ad4c6b9
change bool width to 1 byte
pcmoritz Oct 13, 2017
8fce724
update
pcmoritz Oct 13, 2017
14943a0
deploy workaround
pcmoritz Oct 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cpp/src/arrow/python/python_to_arrow.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,6 @@ Status SerializeArray(PyObject* context, PyArrayObject* array, SequenceBuilder*
std::vector<PyObject*>* tensors_out) {
int dtype = PyArray_TYPE(array);
switch (dtype) {
case NPY_BOOL:
case NPY_UINT8:
case NPY_INT8:
case NPY_UINT16:
Expand Down
2 changes: 1 addition & 1 deletion python/pyarrow/tests/test_serialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ def test_default_dict_serialization(large_memory_map):

def test_numpy_serialization(large_memory_map):
with pa.memory_map(large_memory_map, mode="r+") as mmap:
for t in ["int8", "uint8", "int16", "uint16", "int32", "uint32",
for t in ["bool", "int8", "uint8", "int16", "uint16", "int32", "uint32",
"float16", "float32", "float64"]:
obj = np.random.randint(0, 10, size=(100, 100)).astype(t)
serialization_roundtrip(obj, mmap)
Expand Down