Skip to content

ARROW-14924: [C++] generic fs tests for GcsFileSystem #12127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
coryan wants to merge 1 commit into from
Closed

ARROW-14924: [C++] generic fs tests for GcsFileSystem #12127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions cpp/src/arrow/filesystem/gcsfs_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,34 @@ class GcsIntegrationTest : public ::testing::Test {
std::string bucket_name_;
};

class TestGCSFSGeneric : public GcsIntegrationTest, public GenericFileSystemTest {
public:
void SetUp() override {
GcsIntegrationTest::SetUp();
auto bucket_name = RandomBucketName();
gcs_fs_ = internal::MakeGcsFileSystemForTest(TestGcsOptions());
ASSERT_OK(gcs_fs_->CreateDir(bucket_name, true));
fs_ = std::make_shared<SubTreeFileSystem>(bucket_name, gcs_fs_);
}

protected:
std::shared_ptr<FileSystem> GetEmptyFileSystem() override { return fs_; }

bool have_implicit_directories() const override { return true; }
bool allow_write_file_over_dir() const override { return true; }
bool allow_read_dir_as_file() const override { return true; }
bool allow_move_dir() const override { return false; }
bool allow_append_to_file() const override { return false; }
bool have_directory_mtimes() const override { return false; }
bool have_flaky_directory_tree_deletion() const override { return false; }
bool have_file_metadata() const override { return true; }

std::shared_ptr<GcsFileSystem> gcs_fs_;
std::shared_ptr<FileSystem> fs_;
};

GENERIC_FS_TEST_FUNCTIONS(TestGCSFSGeneric);

TEST(GcsFileSystem, OptionsCompare) {
auto a = GcsOptions::Anonymous();
auto b = a;
Expand Down