ARROW-13617: [C++] Make Decimal representations consistent #12134
Conversation
pitrou
force-pushed
the
ARROW-13617-decimal-common
branch
3 times, most recently
from
456d500 to
d7cbefd
Compare
pitrou
changed the title
pitrou
force-pushed
the
ARROW-13617-decimal-common
branch
7 times, most recently
from
58fc6ad to
1302436
Compare
Factor out some basics of decimal representation and implementation in a generic base class.
pitrou
force-pushed
the
ARROW-13617-decimal-common
branch
from
1302436 to
5d74a90
Compare
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
LGTM, thanks for doing this.
|
@ursabot please benchmark lang=C++ |
|
Benchmark runs are scheduled for baseline = b1a3e8c and contender = 5d74a90. Results will be available as each benchmark for each run completes. |
|
Hmm, hopefully Travis also gets around to building this PR so that we can run the tests on big-endian. |
|
Unfortunately, Travis never runs on my PRs. I have no idea why. |
|
Indeed, this PR isn't in the Travis queue, and I also can't manually trigger a build for a fork from the UI, which is unfortunate. |
|
I ran the s390x tests locally under emulation and they seemed to work (I had to disable Gandiva, though). |
| kRescaleDataLoss, | ||
| }; | ||
|
|
||
| template <typename Derived, int BIT_WIDTH, int NWORDS = BIT_WIDTH / 64> |
There was a problem hiding this comment.
Looks Derived is not used?
| return result; | ||
| } | ||
|
|
||
| // Explicitly instantiate template base class, for DLL linking on Windows |
There was a problem hiding this comment.
Does this approach avoid putting all template class implementation code inside the header?
There was a problem hiding this comment.
It should, though that's not the goal here :-)
IBM provides free s390x cloud instances. I tried, it works. But it expires in half year and you have to apply for a new one. |
|
Benchmark runs are scheduled for baseline = ab86daf and contender = d67a210. d67a210 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
4 participants
Factor out some basics of decimal representation and implementation in a generic base class.