-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-15366: [Docs] Automate incrementing of package version for R and non-R version switchers #12212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-15366: [Docs] Automate incrementing of package version for R and non-R version switchers #12212
Conversation
|
|
|
Can you print an example of what json file the scripts outputs eg for the 7.0 release? |
Certainly can. For the main docs, you manually add the dev version in the JS, right? |
Ah, no, it would actually be good this is handled by the script as well. I added it manually last week directly in the hosted sources (apache/arrow-site#177) to get the dropdown working for the new nightly docs that were added (originally when adding the dropdown, we didn't yet have dev docs). But I should actually have ported that back to the main version of the json file in the apache/arrow repo) |
Just pushed a commit which now results in this; is this what you'd expect? I also noticed that |
|
Yes, that looks good! |
1914e9e to
5ef27e9
Compare
|
Thanks for the feedback and suggestions here @kou ! Now entirely stuck again on test failures - the CI is showing differences between the expected line in one of the I've tried removing it entirely in 1 PR (see CI failure here: https://github.com/apache/arrow/runs/5040927092?check_suite_focus=true#step:6:403) and then copying and pasting the annotated "missing" line into the tests in a subsequent PR (see CI failure here: https://github.com/apache/arrow/runs/5040977997?check_suite_focus=true#step:6:405) but it's still showing up as not matching. I've copied and pasted the two lines and done a diff on them and there's no difference, so I don't know what a sensible next step is here. |
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I've fixed the test failures. I've also fixed versions.json generation when "X.Y (dev)" exists.
|
I've also add missing trailing "/" to dev version. |
|
Benchmark runs are scheduled for baseline = c89e67d and contender = 360252b. 360252b is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
Thanks for finishing off this PR @kou, I was getting pretty frustrated with it, so your help here is much appreciated! :D |
…d non-R version switchers Closes apache#12212 from thisisnic/ARROW-15366_increment_versions Lead-authored-by: Nic Crane <thisisnic@gmail.com> Co-authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
No description provided.