Skip to content

ARROW-15262: [C++] Create a ToTable sink node #12275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vibhatha wants to merge 8 commits into from
Closed

ARROW-15262: [C++] Create a ToTable sink node #12275

vibhatha wants to merge 8 commits into from

Conversation

@vibhatha
Copy link
Contributor

@vibhatha vibhatha commented Jan 27, 2022

This PR includes an addition of a Sink node customized to obtain the output from an streaming execution.

@github-actions
Copy link

github-actions bot commented Jan 27, 2022

https://issues.apache.org/jira/browse/ARROW-15262

@github-actions
Copy link

github-actions bot commented Jan 27, 2022

⚠️ Ticket has no components in JIRA, make sure you assign one.

@github-actions
Copy link

github-actions bot commented Jan 27, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

lidavidm
lidavidm reviewed Jan 27, 2022
View reviewed changes
westonpace
westonpace reviewed Jan 27, 2022
View reviewed changes
@vibhatha
Copy link
Contributor Author

vibhatha commented Feb 1, 2022

@westonpace I updated the PR with review comments. But there is an issue when we remove the future from the Consuming sync node, the process hangs without finishing. Looking into it.

@lidavidm
Copy link
Member

lidavidm commented Feb 1, 2022

I don't think we want to remove the Future from ConsumingSinkNode, but we don't need it in TableSinkNodeOptions.

lidavidm
lidavidm reviewed Feb 1, 2022
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a couple nits

lidavidm
lidavidm reviewed Feb 1, 2022
View reviewed changes
@vibhatha vibhatha requested a review from lidavidm February 2, 2022 01:50
@lidavidm
Copy link
Member

lidavidm commented Feb 4, 2022

LGTM. I think the Dev failure is just because this branch needs to be rebased/it will go away once merged.

@lidavidm lidavidm closed this in 47d5575 Feb 4, 2022
@ursabot
Copy link

ursabot commented Feb 4, 2022 •
edited
Loading

Benchmark runs are scheduled for baseline = 1ff2e19 and contender = 47d5575. 47d5575 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️1.88% ⬆️0.17%] test-mac-arm
[Finished ⬇️0.36% ⬆️0.0%] ursa-i9-9960x
[Failed] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ElenaHenderson ElenaHenderson mentioned this pull request Feb 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidavidm lidavidm lidavidm approved these changes

@westonpace westonpace Awaiting requested review from westonpace

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vibhatha @lidavidm @ursabot @westonpace