ARROW-15067: [C++] Add tracing spans to the scanner #12328
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format? or See also: |
mbrobbel
changed the title
|
|
8 tasks
Member
|
This can be closed in favor of the other PR, right? |
lidavidm
added a commit
that referenced
this pull request
Apr 7, 2022
Continuing #12328 and #11964. The tracing spans were not propagated through all the asynchronous constructs, causing some spans to become disconnected from the trace. This PR aims to address this. Some things left to do: - [x] Possibly add some attributes to the `read_column` span - [x] fix parent/sibling relationships (some of the new spans should probably become a child) - [x] Do something about all the `#ifdefs` - [x] Wrap around a `Future` - [x] Wrap `Executor` - [x] Check if tracing now works properly for all of the file types, not just parquet - [x] lidavidm mentioned some memory leaks that should be investigated - [x] The `FragmentToBatches` span seems to be active way too long Closes #12609 from joosthooz/arrow-15067 Lead-authored-by: Joost Hoozemans <joosthooz@msn.com> Co-authored-by: David Li <li.davidm96@gmail.com> Co-authored-by: Matthijs Brobbel <m1brobbel@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the work of @lidavidm in #11964 in this PR. Rebased on master.