-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-15195: [MATLAB] Enable GitHub Actions CI for MATLAB Interface on macOS #12342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
I've merged #12004. Could you rebase on master? |
2244b46 to
7332b51
Compare
|
Could you remove "Notes 1." from the description? |
I will do another commit to remove 'matlab' from 'matlab-macos'. Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Thank you, @kou, for the feedback. |
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
Benchmark runs are scheduled for baseline = 09c8554 and contender = ac2d8ff. ac2d8ff is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Overview
This Pull Request:
macos-latestVM.v0ofmatlab-actions/setup-matlabenabled forubuntu-latestVM to the lastestv1matlab-actions/setup-matlab.Implementation
This implementation uses
matlab-actionsto automatically install MATLAB into a GitHub Actions Linux and Mac VM.We are using the most updated version:
v1matlab-actions/setup-matlabto enable the CI for Mac.Here are the steps we require to build and run tests on Mac:
brewcommandmatlab-actions/setup-matlab@v1matlab_build.shscript inci/scriptsMATLABPATHenvironment variable to the MATLAB Interface to Apache Arrow installation directorymatlab/testusingmatlab-actions/run-tests@v1Testing
Future Directions
Enable support for Windows:
matlab-actions/setup-matlab@v1supports Windows now. We are working on enabling this for the MATLAB Arrow interface.Notes
Thank you, Fiona @lafiona, for helping me with this pull request to submit the changes for
matlab.yml.