ARROW-15593: [C++] Fix a race condition in the thread pool#12350
Closed
framlog wants to merge 1 commit intoapache:masterfrom
framlog:master
Closed
ARROW-15593: [C++] Fix a race condition in the thread pool#12350framlog wants to merge 1 commit intoapache:masterfrom framlog:master
framlog wants to merge 1 commit intoapache:masterfrom
framlog:master
Conversation
|
|
cyb70289
reviewed
Feb 7, 2022
Test Plan: Manually
pitrou
changed the title
pitrou
reviewed
Feb 7, 2022
| int capacity = 0; | ||
| if (current_pid != old_pid) { | ||
| // FIXME: It may get deadlock here if users fork processes while the parent runs | ||
| // in the middle of resetting states. |
Member
There was a problem hiding this comment.
FTR, I'm working on a better fix for this.
Author
There was a problem hiding this comment.
Great. Feel free to close this then.
Member
|
See PR #12358. The tests I added there sometimes fail with this PR. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Plan: Manually
This closes #12329.