-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-14817 [R] Implement bindings for lubridate::tz()
#12357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
d6b66d2
first pass at implementing the binding for `lubridate::tz()`. needs m…
dragosmg ebc1443
`tz()` returns `"UTC"` for strings, date and NAs + more tests
dragosmg 104c779
updated NEWS
dragosmg 9710ffd
fall back to the simpler implementation for `tz()`
dragosmg 38e38e0
split good and error behaviour in 2 different chunks and use `expect_…
dragosmg d88e4c9
update `tz()` binding to return `NA` when x is `NA`
dragosmg ff23580
update tests to reflect different behaviour for `NA`: arrow returns `…
dragosmg 6014efa
revert to first / original implementation and remove NA propagation u…
dragosmg baaed40
updated unit tests and snapshots for `tz()`
dragosmg badcdb6
update `tz()` with more meaningful error messages
dragosmg f03ab7d
meaningful names for the test dataframe columns + update snapshots
dragosmg 022070a
simplify the implementation (start with timestamp & error for anythin…
dragosmg d47fd4d
some clean up
jonkeane 14d3ac4
removed snapshot md file
dragosmg 52067c9
class extraction
dragosmg 792f4ae
simplify class extraction once #12447 is merged
dragosmg d1d5946
first pass at implementing the binding for `lubridate::tz()`. needs m…
dragosmg 91c5e66
`tz()` returns `"UTC"` for strings, date and NAs + more tests
dragosmg 46080f6
updated NEWS
dragosmg 0233ec5
fall back to the simpler implementation for `tz()`
dragosmg de7f992
split good and error behaviour in 2 different chunks and use `expect_…
dragosmg 07c2a65
update `tz()` binding to return `NA` when x is `NA`
dragosmg 0936441
update tests to reflect different behaviour for `NA`: arrow returns `…
dragosmg de648f4
revert to first / original implementation and remove NA propagation u…
dragosmg 165031c
updated unit tests and snapshots for `tz()`
dragosmg 30e2cea
update `tz()` with more meaningful error messages
dragosmg 384fddc
meaningful names for the test dataframe columns + update snapshots
dragosmg af96552
simplify the implementation (start with timestamp & error for anythin…
dragosmg 3cee34a
some clean up
jonkeane fa75502
removed snapshot md file
dragosmg 4bf48f6
class extraction
dragosmg 554345b
simplify class extraction once #12447 is merged
dragosmg 3bff651
a few test additions|changes
jonkeane ea3a395
Merge branch 'lubridate_tz_binding' of https://github.com/dragosmg/ar…
dragosmg 85c079c
update the `type` method for `Expression` to return a function + more…
dragosmg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.