Skip to content

ARROW-15659 [R] strptime should return NA (not error) with format mismatch #12402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dragosmg wants to merge 13 commits into from
Closed

ARROW-15659 [R] strptime should return NA (not error) with format mismatch #12402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1ead9c5
add unit test to show the different returns from strptime with mistma…
dragosmg Feb 11, 2022
962ca1b
`strptime` returns `NA` / `NULL` instead of error
dragosmg Mar 25, 2022
48eee0a
add failing unit test
dragosmg Mar 25, 2022
4894e8b
added a C++ unit test to try and replicate the weird behavior i notic…
dragosmg Mar 28, 2022
10708d7
extend the C++ test
dragosmg Mar 28, 2022
3d56e03
unit test for the `"%m/%d/%Y %z"` format
dragosmg Mar 28, 2022
96108a5
test
dragosmg Mar 28, 2022
870ca53
cleaned-up tests
dragosmg Mar 28, 2022
cb4ecd5
use `build_expr()` to support regular R objects too
dragosmg Mar 28, 2022
c696fb7
added unit test for R objects
dragosmg Mar 28, 2022
e10bb1e
removed the C++ unit tests
dragosmg Mar 29, 2022
5d19668
testing with NA
dragosmg Mar 29, 2022
f669be7
updated tests to be more `compare_dplyr`-like
dragosmg Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion r/R/dplyr-funcs-datetime.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ register_bindings_datetime <- function() {

unit <- make_valid_time_unit(unit, c(valid_time64_units, valid_time32_units))

Expression$create("strptime", x, options = list(format = format, unit = unit))
build_expr("strptime", x, options = list(format = format, unit = unit, error_is_null = TRUE))
})

register_binding("strftime", function(x, format = "", tz = "", usetz = FALSE) {
Expand Down
42 changes: 42 additions & 0 deletions r/tests/testthat/test-dplyr-funcs-datetime.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,48 @@ test_that("errors in strptime", {
)
})

test_that("strptime returns NA when format doesn't match the data", {
df <- tibble(
str_date = c("2022-02-07", "2012/02-07", "1975/01-02", "1981/01-07", NA)
)

# base::strptime() returns a POSIXlt object (a list), while the Arrow binding
# returns a POSIXct (double) vector => we cannot use compare_dplyr_binding()
expect_equal(
df %>%
arrow_table() %>%
mutate(
r_obj_parsed_date = strptime("03-27/2022", format = "%m-%d/%Y"),
r_obj_parsed_na = strptime("03-27/2022", format = "Y%-%m-%d")) %>%
collect(),
df %>%
mutate(
r_obj_parsed_date = as.POSIXct(strptime("03-27/2022", format = "%m-%d/%Y")),
r_obj_parsed_na = as.POSIXct(strptime("03-27/2022", format = "Y%-%m-%d"))),
ignore_attr = "tzone"
)

expect_equal(
df %>%
record_batch() %>%
mutate(parsed_date = strptime(str_date, format = "%Y-%m-%d")) %>%
collect(),
df %>%
mutate(parsed_date = as.POSIXct(strptime(str_date, format = "%Y-%m-%d"))),
ignore_attr = "tzone"
)

expect_equal(
df %>%
arrow_table() %>%
mutate(parsed_date = strptime(str_date, format = "%Y/%m-%d")) %>%
collect(),
df %>%
mutate(parsed_date = as.POSIXct(strptime(str_date, format = "%Y/%m-%d"))),
ignore_attr = "tzone"
)
})

test_that("strftime", {
times <- tibble(
datetime = c(lubridate::ymd_hms("2018-10-07 19:04:05", tz = "Etc/GMT+6"), NA),
Expand Down