Skip to content

Conversation

@nealrichardson
Copy link
Member

Included a few other master-related cleanups I saw

@github-actions
Copy link

@nealrichardson
Copy link
Member Author

I'll back out the R windows job changes for now, they're unrelated (they're about the r-lib/actions tag, not our master branch). It looks like pacman isn't on the path in the v2 workflows (r-lib/actions@master...v2-branch#diff-3e2a1a7f497c1884dc161d6e07fdc58e4853eb91bf13034122e3814b501df0d5L382), I'll follow up with that upstream.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check that no existing CI job was passing "master" to this script?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, it's simply redundant with the else branch below?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can safely remove this branch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here.

@pitrou pitrou requested a review from kszucs February 16, 2022 10:52
@kszucs
Copy link
Member

kszucs commented Feb 16, 2022

@nealrichardson it looks good to me, but the R builds are failing.

@nealrichardson
Copy link
Member Author

@nealrichardson it looks good to me, but the R builds are failing.

@kszucs I fixed the issue upstream, builds passed this time

@kszucs kszucs closed this in ee9354d Feb 16, 2022
@ursabot
Copy link

ursabot commented Feb 16, 2022

Benchmark runs are scheduled for baseline = e4e866f and contender = ee9354d. ee9354d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Failed] ursa-i9-9960x
[Failed] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@nealrichardson nealrichardson deleted the default-branch-1 branch February 16, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants