-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-15690: [Dev] Update GitHub Actions workflows that hardcode master as default #12436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'll back out the R windows job changes for now, they're unrelated (they're about the r-lib/actions tag, not our master branch). It looks like pacman isn't on the path in the v2 workflows (r-lib/actions@master...v2-branch#diff-3e2a1a7f497c1884dc161d6e07fdc58e4853eb91bf13034122e3814b501df0d5L382), I'll follow up with that upstream. |
ci/scripts/install_kartothek.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check that no existing CI job was passing "master" to this script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, it's simply redundant with the else branch below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can safely remove this branch.
ci/scripts/install_turbodbc.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question here.
|
@nealrichardson it looks good to me, but the R builds are failing. |
755d08d to
04e7b3b
Compare
@kszucs I fixed the issue upstream, builds passed this time |
|
Benchmark runs are scheduled for baseline = e4e866f and contender = ee9354d. ee9354d is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Included a few other master-related cleanups I saw