Skip to content

ARROW-15712 [R] Add a type method for Expression objects #12447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dragosmg wants to merge 2 commits into from
Closed

ARROW-15712 [R] Add a type method for Expression objects #12447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ded44ac
add & export type method for `Expression` + unit test
dragosmg Feb 17, 2022
24a4a39
update unit tests
dragosmg Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions r/NAMESPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ S3method(tail,RecordBatchReader)
S3method(tail,Scanner)
S3method(tail,arrow_dplyr_query)
S3method(type,ArrowDatum)
S3method(type,Expression)
S3method(type,default)
S3method(unique,ArrowDatum)
S3method(vec_ptype_abbr,arrow_fixed_size_binary)
Expand Down
3 changes: 3 additions & 0 deletions r/R/type.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@ type.default <- function(x) Array__infer_type(x)
#' @export
type.ArrowDatum <- function(x) x$type

#' @export
type.Expression <- function(x) x$type

#----- metadata

#' @title class arrow::FixedWidthType
Expand Down
10 changes: 10 additions & 0 deletions r/tests/testthat/test-type.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,3 +229,13 @@ test_that("Type strings are correctly canonicalized", {
"Unrecognized"
)
})

test_that("type() gets the right type for Expression", {
x <- Expression$scalar(32L)
y <- Expression$scalar(10)
add_xy <- Expression$create("add", x, y)

expect_equal(x$type, type(x))
expect_equal(y$type, type(y))
expect_equal(add_xy$type, type(add_xy))
})