Skip to content

ARROW-15760: [C++] Avoid hard dependency on git in cmake (download tarballs from github instead) #12494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mbrobbel wants to merge 3 commits into from
Closed

ARROW-15760: [C++] Avoid hard dependency on git in cmake (download tarballs from github instead) #12494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bebc7c
Direct download Substrait source tarball instead of using git clone
mbrobbel Feb 23, 2022
c173a8b
Update cpp/src/arrow/engine/CMakeLists.txt
mbrobbel Feb 23, 2022
8613684
ARROW_SUBSTRAIT_REPO URL download is GitHub specific
mbrobbel Feb 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cpp/cmake_modules/DefineOptions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,10 +478,11 @@ advised that if this is enabled 'install' will fail silently on components;\
that have not been built"
OFF)

set(ARROW_SUBSTRAIT_REPO_DEFAULT "https://github.com/substrait-io/substrait")
set(ARROW_SUBSTRAIT_REPO_DEFAULT "substrait-io/substrait")
define_option_string(ARROW_SUBSTRAIT_REPO
"Custom git repository URL for downloading Substrait sources.;\
See also ARROW_SUBSTRAIT_TAG" "${ARROW_SUBSTRAIT_REPO_DEFAULT}")
"Custom GitHub user/repository pair for downloading Substrait sources.;\
See also ARROW_SUBSTRAIT_TAG"
"${ARROW_SUBSTRAIT_REPO_DEFAULT}")

set(ARROW_SUBSTRAIT_TAG_DEFAULT "e1b4c04a1b518912f4c4065b16a1b2c0ac8e14cf")
define_option_string(ARROW_SUBSTRAIT_TAG
Expand Down
3 changes: 1 addition & 2 deletions cpp/src/arrow/engine/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@ set(SUBSTRAIT_PROTOS
type_expressions)

externalproject_add(substrait_ep
GIT_REPOSITORY "${ARROW_SUBSTRAIT_REPO}"
GIT_TAG "${ARROW_SUBSTRAIT_TAG}"
URL "https://github.com/${ARROW_SUBSTRAIT_REPO}/archive/${ARROW_SUBSTRAIT_TAG}.tar.gz"
SOURCE_DIR "${SUBSTRAIT_LOCAL_DIR}"
CONFIGURE_COMMAND ""
BUILD_COMMAND ""
Expand Down