Skip to content

ARROW-15707: [C++][FlightRPC] Make Flight tests more resuable across transports #12499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lidavidm wants to merge 5 commits into from
+1,742 −1,454
Closed

ARROW-15707: [C++][FlightRPC] Make Flight tests more resuable across transports #12499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f8124c8
ARROW-15707: [C++][FlightRPC] Split out Flight tests that don't use t…
lidavidm Feb 23, 2022
b17d1a0
ARROW-15707: [C++][FlightRPC] Make Flight data plane tests reusable
lidavidm Feb 24, 2022
e26a09c
ARROW-15707: [C++][FlightRPC] Try to fix Windows issues
lidavidm Feb 24, 2022
c4baa98
ARROW-15707: [C++][FlightRPC] Try to fix Windows issues with another …
lidavidm Feb 25, 2022
5f9851e
ARROW-15707: [C++][FlightRPC] Remove note
lidavidm Feb 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions cpp/src/arrow/flight/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ if(ARROW_TESTING)
OUTPUTS
ARROW_FLIGHT_TESTING_LIBRARIES
SOURCES
test_definitions.cc
test_util.cc
DEPENDENCIES
GTest::gtest
Expand All @@ -237,6 +238,12 @@ foreach(LIB_TARGET ${ARROW_FLIGHT_TESTING_LIBRARIES})
${ARROW_BOOST_PROCESS_COMPILE_DEFINITIONS})
endforeach()

add_arrow_test(flight_internals_test
STATIC_LINK_LIBS
${ARROW_FLIGHT_TEST_LINK_LIBS}
LABELS
"arrow_flight")

add_arrow_test(flight_test
STATIC_LINK_LIBS
${ARROW_FLIGHT_TEST_LINK_LIBS}
Expand Down
10 changes: 5 additions & 5 deletions cpp/src/arrow/flight/flight_cuda_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,16 +70,16 @@ class CudaTestServer : public FlightServerBase {

Status DoGet(const ServerCallContext&, const Ticket&,
std::unique_ptr<FlightDataStream>* data_stream) override {
BatchVector batches;
RecordBatchVector batches;
RETURN_NOT_OK(ExampleIntBatches(&batches));
auto batch_reader = std::make_shared<BatchIterator>(batches[0]->schema(), batches);
ARROW_ASSIGN_OR_RAISE(auto batch_reader, RecordBatchReader::Make(batches));
*data_stream = std::unique_ptr<FlightDataStream>(new RecordBatchStream(batch_reader));
return Status::OK();
}

Status DoPut(const ServerCallContext&, std::unique_ptr<FlightMessageReader> reader,
std::unique_ptr<FlightMetadataWriter> writer) override {
BatchVector batches;
RecordBatchVector batches;
RETURN_NOT_OK(reader->ReadAll(&batches));
for (const auto& batch : batches) {
for (const auto& column : batch->columns()) {
Expand Down Expand Up @@ -161,7 +161,7 @@ TEST_F(TestCuda, DoGet) {
TEST_F(TestCuda, DoPut) {
// Check that we can send a record batch containing references to
// GPU buffers.
BatchVector batches;
RecordBatchVector batches;
ASSERT_OK(ExampleIntBatches(&batches));

std::unique_ptr<FlightStreamWriter> writer;
Expand Down Expand Up @@ -190,7 +190,7 @@ TEST_F(TestCuda, DoExchange) {
FlightCallOptions options;
options.memory_manager = device_->default_memory_manager();

BatchVector batches;
RecordBatchVector batches;
ASSERT_OK(ExampleIntBatches(&batches));

std::unique_ptr<FlightStreamWriter> writer;
Expand Down
Loading