-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-15871: [Python] Start raising deprecation warnings for ParquetDataset keywords that won't be supported with the new API #12585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@github-actions crossbow submit -g integration |
|
Revision: 0001bf47ac4b5916234eae79f689eaa5f10de889 Submitted crossbow builds: ursacomputing/crossbow @ actions-1729 |
python/pyarrow/parquet.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "Specifying the 'metadata_nthreads' keyword is deprecated as " | |
| "of pyarrow 8.0.0, and the keyword will be removed in a " | |
| "future version", | |
| "Specifying the 'metadata_nthreads' argument is deprecated as " | |
| "of pyarrow 8.0.0, and the keyword will be argument in a " | |
| "future version", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(may need reformatting after this change?)
python/pyarrow/parquet.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here as well, say "argument" not "keyword".
0001bf4 to
2b5345e
Compare
… it in the non-legacy read_table
|
I forgot about this PR. I rebased and will merge if green. |
|
@github-actions crossbow submit -g integration |
|
Revision: 6ebd216 Submitted crossbow builds: ursacomputing/crossbow @ actions-1805 |
|
Benchmark runs are scheduled for baseline = ba04e7f and contender = ea4ab77. ea4ab77 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Added warnings for when passing the
schemaandmetadata_nthreadskeywords.For
schema, also enabled this keyword for the new implementation (passing through theschemakeyword to the datasets API), but so in this case this is about a pyarrow.Schema and not a ParquetSchema that should be passed.