Skip to content

ARROW-16156: [R] Clarify warning message for features not turned on in .onAttach() #12842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
paleolimbot wants to merge 2 commits into from
Closed

ARROW-16156: [R] Clarify warning message for features not turned on in .onAttach() #12842

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad3d9aa
add 'engine' to to the list of capabilities we don't care about; clar…
paleolimbot Apr 8, 2022
e8ecc22
Update r/R/arrow-package.R
paleolimbot Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions r/R/arrow-package.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,12 @@
#
# Let's print a message if some are off
if (some_features_are_off(features)) {
packageStartupMessage("See arrow_info() for available features")
packageStartupMessage(
paste(
"Some features are not enabled in this build of Arrow.",
"Run `arrow_info()` for more information."
)
)
}
})
}
Expand Down Expand Up @@ -264,7 +269,7 @@ arrow_info <- function() {
some_features_are_off <- function(features) {
# `features` is a named logical vector (as in arrow_info()$capabilities)
# Let's exclude some less relevant ones
blocklist <- c("lzo", "bz2", "brotli")
blocklist <- c("lzo", "bz2", "brotli", "engine")
# Return TRUE if any of the other features are FALSE
!all(features[setdiff(names(features), blocklist)])
}
Expand Down