Skip to content

Conversation

@cyb70289
Copy link
Contributor

No description provided.

@github-actions
Copy link

Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@cyb70289 cyb70289 marked this pull request as draft April 18, 2022 06:28
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turn this PR to draft to rebase on #12861

@kou
Copy link
Member

kou commented May 12, 2022

Could you rebase on master so that we can use #12861 changes.

@cyb70289 cyb70289 marked this pull request as ready for review May 12, 2022 03:03
@cyb70289
Copy link
Contributor Author

cyb70289 commented May 12, 2022

UCX is not enabled in CI. I tested this PR offline with building from source and setting ucx_DIR to pre-built binaries, both on Linux.

@cyb70289 cyb70289 requested review from kou and lidavidm May 12, 2022 03:09
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I confirmed this on my local Debian GNU/Linux sid machine.

@lidavidm lidavidm closed this in 0653113 May 12, 2022
@cyb70289 cyb70289 deleted the 16183-bundled-ucx branch May 13, 2022 00:50
@ursabot
Copy link

ursabot commented May 14, 2022

Benchmark runs are scheduled for baseline = ccfae42 and contender = 0653113. 0653113 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.39% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.71% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️1.18% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 06531131 ec2-t3-xlarge-us-east-2
[Finished] 06531131 test-mac-arm
[Finished] 06531131 ursa-i9-9960x
[Finished] 06531131 ursa-thinkcentre-m75q
[Finished] ccfae42b ec2-t3-xlarge-us-east-2
[Finished] ccfae42b test-mac-arm
[Finished] ccfae42b ursa-i9-9960x
[Finished] ccfae42b ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants