Skip to content

Conversation

@okadakk
Copy link
Contributor

@okadakk okadakk commented Apr 16, 2022

I added test for Arrow::DictionaryArray#raw_records.

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm. This dictionary isn't a dictionary.

For example, Arrow::NullArray.new(records.flatten) in build(Arrow::NullArray.new(records.flatten), records) isn't a dictionary.

How about something like the following?

def build_record_batch(array)
  dictionary = array.dictionary_encode
  schema = Arrow::Schema.new(column: dictionary.value_data_type)
  Arrow::RecordBatch.new(schema, array.length, [dictionary])
end
target = build(Arrow::NullArray.new(records.collect(&:first)))

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@okadakk
Copy link
Contributor Author

okadakk commented May 19, 2022

thanks! Sorry for the late reaction...

@okadakk okadakk deleted the arrow-ruby-add-test-for-arrow-dictionary-array-raw-records branch May 19, 2022 08:22
@kou
Copy link
Member

kou commented May 19, 2022

No problem! But please mention me when a pull request can be reviewed again.

@ursabot
Copy link

ursabot commented May 19, 2022

Benchmark runs are scheduled for baseline = dc39f83 and contender = 79810a5. 79810a5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️1.05% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.37% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.16% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 79810a54 ec2-t3-xlarge-us-east-2
[Failed] 79810a54 test-mac-arm
[Failed] 79810a54 ursa-i9-9960x
[Finished] 79810a54 ursa-thinkcentre-m75q
[Finished] dc39f83e ec2-t3-xlarge-us-east-2
[Failed] dc39f83e test-mac-arm
[Failed] dc39f83e ursa-i9-9960x
[Finished] dc39f83e ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants