Skip to content

ARROW-16216: [Python][FlightRPC] Fix test_flight.py when Flight is not available #12911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lidavidm wants to merge 1 commit into from
Closed

ARROW-16216: [Python][FlightRPC] Fix test_flight.py when Flight is not available #12911

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions python/pyarrow/tests/test_flight.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,20 +355,23 @@ def slow_stream():
class ErrorFlightServer(FlightServerBase):
"""A Flight server that uses all the Flight-specific errors."""

errors = {
"internal": flight.FlightInternalError,
"timedout": flight.FlightTimedOutError,
"cancel": flight.FlightCancelledError,
"unauthenticated": flight.FlightUnauthenticatedError,
"unauthorized": flight.FlightUnauthorizedError,
"notimplemented": NotImplementedError,
"invalid": pa.ArrowInvalid,
"key": KeyError,
}
@staticmethod
def error_cases():
return {
"internal": flight.FlightInternalError,
"timedout": flight.FlightTimedOutError,
"cancel": flight.FlightCancelledError,
"unauthenticated": flight.FlightUnauthenticatedError,
"unauthorized": flight.FlightUnauthorizedError,
"notimplemented": NotImplementedError,
"invalid": pa.ArrowInvalid,
"key": KeyError,
}

def do_action(self, context, action):
if action.type in self.errors:
raise self.errors[action.type]("foo")
error_cases = ErrorFlightServer.error_cases()
if action.type in error_cases:
raise error_cases[action.type]("foo")
elif action.type == "protobuf":
err_msg = b'this is an error message'
raise flight.FlightUnauthorizedError("foo", err_msg)
Expand Down Expand Up @@ -1564,7 +1567,7 @@ def test_roundtrip_errors():
with ErrorFlightServer() as server, \
FlightClient(('localhost', server.port)) as client:

for arg, exc_type in ErrorFlightServer.errors.items():
for arg, exc_type in ErrorFlightServer.error_cases().items():
with pytest.raises(exc_type, match=".*foo.*"):
list(client.do_action(flight.Action(arg, b"")))
with pytest.raises(flight.FlightInternalError, match=".*foo.*"):
Expand Down