Skip to content

ARROW-11415: [R] map_batches wouldn't accept a dataset as an argument #12948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wjones127 wants to merge 1 commit into from
+9 −1
Closed

ARROW-11415: [R] map_batches wouldn't accept a dataset as an argument #12948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion r/R/dataset-scan.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ tail_from_batches <- function(batches, n) {
map_batches <- function(X, FUN, ..., .data.frame = TRUE) {
# TODO: ARROW-15271 possibly refactor do_exec_plan to return a RecordBatchReader
plan <- ExecPlan$create()
final_node <- plan$Build(X)
final_node <- plan$Build(as_adq(X))
reader <- plan$Run(final_node)
FUN <- as_mapper(FUN)

Expand Down
8 changes: 8 additions & 0 deletions r/tests/testthat/test-dataset.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,14 @@ test_that("map_batches", {
c(5, 10)
)

# Can take a raw dataset as X argument
expect_equal(
ds %>%
map_batches(~ count(., part)) %>%
arrange(part),
tibble(part = c(1, 2), n = c(10, 10))
)

# $Take returns RecordBatch, which gets binded into a tibble
expect_equal(
ds %>%
Expand Down