ARROW-16374: [R] [C++] skip another snappy test during sanitizer runs #13014
Conversation
|
@github-actions crossbow submit test-fedora-r-clang-sanitizer |
| }) | ||
|
|
||
| test_that("read_parquet() and write_parquet() accept connection objects", { | ||
| skip_if_not_available("snappy") |
There was a problem hiding this comment.
The other way to do this would be to specify no compression in write_parquet(). That plus a comment explaining why is probably clearer since skip_if_not_available("snappy") isn't actually what's happening (snappy is available in the build but the function still skips on linux devel to avoid sanitizers)
There was a problem hiding this comment.
Yeah, I've been thinking about how may of these we need + it would be great if we actually tested this with our default and then fell back on sanitizers only. Either compression should be totally fine, but it would be nice to have coverage on both. But we should do that generally. I'll make a Jira for that + we can do that outside of the release pressure.
There was a problem hiding this comment.
|
|
|
Revision: 1e86276 Submitted crossbow builds: ursacomputing/crossbow @ actions-1978
|
|
Benchmark runs are scheduled for baseline = b048937 and contender = f03f090. f03f090 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
3 participants
Another example of google/snappy#148