Skip to content

ARROW-16083: [C++] Implement AsofJoin execution node #13028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
westonpace merged 47 commits into from
Jun 24, 2022
Merged

ARROW-16083: [C++] Implement AsofJoin execution node #13028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
23b8c71
wip
icexelloss Apr 18, 2022
f4b2106
wip
icexelloss Apr 18, 2022
7ab446d
wip
icexelloss Apr 21, 2022
138daee
wip
icexelloss Apr 26, 2022
94a8453
wip: First test pass
icexelloss Apr 26, 2022
6466b80
Fix code style and lint (partial)
icexelloss Apr 28, 2022
4c33452
Add support for mutliple tables; Add more tests
icexelloss May 9, 2022
c6c6093
Clean up code style (Pass ninja lint now), switch to unbounded queue
icexelloss May 10, 2022
643e368
Clean up some files
icexelloss May 10, 2022
0781a16
Clean up some files
icexelloss May 11, 2022
fc75844
Minor clean up
icexelloss May 11, 2022
26bc862
Fix nulls in test result
icexelloss May 11, 2022
5a6afbd
Clean up includes
icexelloss May 11, 2022
4f7cac7
Clean up error handling
icexelloss May 12, 2022
8773317
Error handling
icexelloss May 12, 2022
22c9941
Fix compiler warning
icexelloss May 17, 2022
6b27e6b
Fix Wshorten-64-to-32 error
icexelloss May 23, 2022
775be1d
Fix lint
icexelloss May 23, 2022
2dc5691
Fix lint
icexelloss May 23, 2022
a9dd980
Fix compiler warning Wunused-result
icexelloss May 24, 2022
0f39fce
Fix format
icexelloss May 24, 2022
761e5de
Remove debug statement
icexelloss May 24, 2022
0387e5c
Update cpp/src/arrow/compute/exec/asof_join_node.cc
icexelloss May 26, 2022
15ba43d
Update cpp/src/arrow/compute/exec/asof_join_node.cc
icexelloss May 26, 2022
b92a303
Update cpp/src/arrow/compute/exec/asof_join_node.cc
icexelloss May 26, 2022
f0edd17
Update cpp/src/arrow/compute/exec/asof_join.h
icexelloss May 26, 2022
58f229d
Update cpp/src/arrow/compute/exec/asof_join_node.cc
icexelloss May 26, 2022
15e2783
Update cpp/src/arrow/compute/exec/asof_join_node.cc
icexelloss May 31, 2022
7aa252a
Update cpp/src/arrow/compute/exec/asof_join_node.cc
icexelloss May 31, 2022
9c332eb
Apply suggestions from code review
icexelloss May 31, 2022
cae5592
Address PR comments
icexelloss May 31, 2022
8f32500
Took another pass of remaing functions to mixed style
icexelloss May 31, 2022
eead16e
ninja lint
icexelloss May 31, 2022
d0aec2f
Remove asof_join.h
icexelloss Jun 1, 2022
f783818
Address comments
icexelloss Jun 1, 2022
1a79d10
Clean up tests
icexelloss Jun 1, 2022
83398c8
ninja format
icexelloss Jun 1, 2022
9f3d5c9
Use implicit ctor for optional
icexelloss Jun 1, 2022
e61b9c1
Refactor tests
icexelloss Jun 1, 2022
1b4f26b
Address comments and add check/test for unsuported datatypes
icexelloss Jun 2, 2022
121b3bd
Apply suggestions from code review
icexelloss Jun 14, 2022
66b6b98
Apply suggestions from code review
icexelloss Jun 14, 2022
478f3b7
Address comments
icexelloss Jun 21, 2022
b33effa
Remove debug statement
icexelloss Jun 21, 2022
be417c3
Fix minor comment
icexelloss Jun 21, 2022
1261e20
Fix lint
icexelloss Jun 21, 2022
26fae6d
Fix lint again
icexelloss Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cpp/src/arrow/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,7 @@ if(ARROW_COMPUTE)
compute/cast.cc
compute/exec.cc
compute/exec/aggregate_node.cc
compute/exec/asof_join_node.cc
compute/exec/bloom_filter.cc
compute/exec/exec_plan.cc
compute/exec/expression.cc
Expand Down
5 changes: 5 additions & 0 deletions cpp/src/arrow/compute/exec/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ add_arrow_compute_test(hash_join_node_test
hash_join_node_test.cc
bloom_filter_test.cc
key_hash_test.cc)
add_arrow_compute_test(asof_join_node_test
PREFIX
"arrow-compute"
SOURCES
asof_join_node_test.cc)
add_arrow_compute_test(tpch_node_test PREFIX "arrow-compute")
add_arrow_compute_test(union_node_test PREFIX "arrow-compute")
add_arrow_compute_test(util_test PREFIX "arrow-compute")
Expand Down
Loading