-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-16426: [C++] Add TeeNode to execution engine #13040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
@westonpace, the build failures shows a dependency problem in some of the platforms. I'm not sure how to resolve this. |
|
Ah, it seems Although exposing things tends to have somewhat infectious consequences. For example, I'm pretty sure you will then also need to expose |
westonpace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clever idea. Only a few minor suggestions.
|
@westonpace, the |
|
I agree it is unrelated. In the future, if there are build failures and they seem unrelated feel free to just mention something like "build failures seem unrelated" and (assuming its ready) re-request review. |
|
Benchmark runs are scheduled for baseline = d00caa9 and contender = 7bfc732. 7bfc732 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
The existing write node is a consuming one while the proposed tee node is a pass-through one.