Skip to content

ARROW-16253: [R] Helper function for casting from float to duration via int64() #13055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dragosmg wants to merge 7 commits into from
Closed

ARROW-16253: [R] Helper function for casting from float to duration via int64() #13055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
199242a
use `make_duration()` helper when defining `make_difftime()`
dragosmg May 3, 2022
b4ccc08
added comment why `make_duration()` is not a good fit here
dragosmg May 3, 2022
5ea1351
used `make_duration()` for `date_decimal()` and simplify casting chai…
dragosmg May 9, 2022
b3d5b5b
Merge branch 'master' into duration_casting_helper
dragosmg May 9, 2022
ae8a253
redo changes post master merge
dragosmg May 9, 2022
c346f60
use `make_duration()` inside `as.difftime()`
dragosmg May 9, 2022
5e78661
update comment to match logic
dragosmg May 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions r/R/dplyr-datetime-helpers.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,13 +142,9 @@ binding_as_date_numeric <- function(x, origin = "1970-01-01") {

if (origin != "1970-01-01") {
delta_in_sec <- call_binding("difftime", origin, "1970-01-01")
# TODO: revisit once either of these issues is addressed:
# https://issues.apache.org/jira/browse/ARROW-16253 (helper function for
# casting from double to duration) or
# https://issues.apache.org/jira/browse/ARROW-15862 (casting from int32
# -> duration or double -> duration)
delta_in_sec <- build_expr("cast", delta_in_sec, options = cast_options(to_type = int64()))
delta_in_days <- (delta_in_sec / 86400L)$cast(int32())
# TODO revisit once https://issues.apache.org/jira/browse/ARROW-15862
# (casting from int32 -> duration or double -> duration) is addressed
delta_in_days <- (delta_in_sec$cast(int64()) / 86400L)$cast(int32())
x <- build_expr("+", x, delta_in_days)
}

Expand Down
12 changes: 5 additions & 7 deletions r/R/dplyr-funcs-datetime.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,8 +351,8 @@ register_bindings_datetime_conversion <- function() {

fraction <- decimal - y
delta <- build_expr("floor", seconds * fraction)
delta <- delta$cast(int64())
start + delta$cast(duration("s"))
delta <- make_duration(delta, "s")
start + delta
})
}

Expand Down Expand Up @@ -412,9 +412,8 @@ register_bindings_duration <- function() {

if (call_binding("is.character", x)) {
x <- build_expr("strptime", x, options = list(format = format, unit = 0L))
# complex casting only due to cast type restrictions: time64 -> int64 -> duration(us)
# and then we cast to duration ("s") at the end
x <- x$cast(time64("us"))$cast(int64())$cast(duration("us"))
# we do a final cast to duration ("s") at the end
x <- make_duration(x$cast(time64("us")), unit = "us")
}

# numeric -> duration not supported in Arrow yet so we use int64() as an
Expand Down Expand Up @@ -459,8 +458,7 @@ register_bindings_duration_constructor <- function() {
duration <- duration_from_chunks(chunks)
}

duration <- build_expr("cast", duration, options = cast_options(to_type = int64()))
duration$cast(duration("s"))
make_duration(duration, "s")
})
}

Expand Down