Skip to content

ARROW-16548: [Python] Add pytest.mark.parquet to all tests under tests/parquet package #13147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
raulcd wants to merge 2 commits into from
Closed

ARROW-16548: [Python] Add pytest.mark.parquet to all tests under tests/parquet package #13147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d138ba
ARROW-16548: [Python] Add pytest.mark.parquet to all tests under test…
raulcd May 13, 2022
a2276f4
Remove manual test marking via pytest_collection_modifyitems and add …
raulcd May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions python/pyarrow/tests/parquet/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,6 @@
pytest.param(False, marks=pytest.mark.dataset)]
)

# Marks all of the tests in this module
# Ignore these with pytest ... -m 'not parquet'
pytestmark = pytest.mark.parquet


def _write_table(table, path, **kwargs):
# So we see the ImportError somewhere
Expand Down
5 changes: 5 additions & 0 deletions python/pyarrow/tests/parquet/test_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@
pd = tm = None


# Marks all of the tests in this module
# Ignore these with pytest ... -m 'not parquet'
pytestmark = pytest.mark.parquet


def test_parquet_invalid_version(tempdir):
table = pa.table({'a': [1, 2, 3]})
with pytest.raises(ValueError, match="Unsupported Parquet format version"):
Expand Down
5 changes: 5 additions & 0 deletions python/pyarrow/tests/parquet/test_compliant_nested_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@
pd = tm = None


# Marks all of the tests in this module
# Ignore these with pytest ... -m 'not parquet'
pytestmark = pytest.mark.parquet


# Tests for ARROW-11497
_test_data_simple = [
{'items': [1, 2]},
Expand Down
5 changes: 5 additions & 0 deletions python/pyarrow/tests/parquet/test_data_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@
pd = tm = None


# Marks all of the tests in this module
# Ignore these with pytest ... -m 'not parquet'
pytestmark = pytest.mark.parquet


# General roundtrip of data types
# -----------------------------------------------------------------------------

Expand Down
5 changes: 5 additions & 0 deletions python/pyarrow/tests/parquet/test_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@
pd = tm = None


# Marks all of the tests in this module
# Ignore these with pytest ... -m 'not parquet'
pytestmark = pytest.mark.parquet


@pytest.mark.pandas
def test_parquet_piece_read(tempdir):
df = _test_dataframe(1000)
Expand Down
5 changes: 5 additions & 0 deletions python/pyarrow/tests/parquet/test_datetime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@
pd = tm = None


# Marks all of the tests in this module
# Ignore these with pytest ... -m 'not parquet'
pytestmark = pytest.mark.parquet


@pytest.mark.pandas
@parametrize_legacy_dataset
def test_pandas_parquet_datetime_tz(use_legacy_dataset):
Expand Down
2 changes: 2 additions & 0 deletions python/pyarrow/tests/parquet/test_encryption.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@

# Marks all of the tests in this module
# Ignore these with pytest ... -m 'not parquet_encryption'
# Ignore these with pytest ... -m 'not parquet'
pytestmark = pytest.mark.parquet_encryption
pytestmark = pytest.mark.parquet
Copy link
Member

@jorisvandenbossche jorisvandenbossche May 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, we can't assign two marks this way (it is redefining the same variable), it should be something like pytestmark = [..., ...] I think



@pytest.fixture(scope='module')
Expand Down
5 changes: 5 additions & 0 deletions python/pyarrow/tests/parquet/test_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@
pd = tm = None


# Marks all of the tests in this module
# Ignore these with pytest ... -m 'not parquet'
pytestmark = pytest.mark.parquet


@pytest.mark.pandas
def test_parquet_metadata_api():
df = alltypes_sample(size=10000)
Expand Down
5 changes: 5 additions & 0 deletions python/pyarrow/tests/parquet/test_pandas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@
pd = tm = None


# Marks all of the tests in this module
# Ignore these with pytest ... -m 'not parquet'
pytestmark = pytest.mark.parquet


@pytest.mark.pandas
def test_pandas_parquet_custom_metadata(tempdir):
df = alltypes_sample(size=10000)
Expand Down
5 changes: 5 additions & 0 deletions python/pyarrow/tests/parquet/test_parquet_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@
pd = tm = None


# Marks all of the tests in this module
# Ignore these with pytest ... -m 'not parquet'
pytestmark = pytest.mark.parquet


@pytest.mark.pandas
def test_pass_separate_metadata():
# ARROW-471
Expand Down
5 changes: 5 additions & 0 deletions python/pyarrow/tests/parquet/test_parquet_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@
pd = tm = None


# Marks all of the tests in this module
# Ignore these with pytest ... -m 'not parquet'
pytestmark = pytest.mark.parquet


@pytest.mark.pandas
@parametrize_legacy_dataset
def test_parquet_incremental_file_build(tempdir, use_legacy_dataset):
Expand Down