Skip to content

ARROW-16568: [Java] Enable skipping BOUNDS_CHECKING with setBytes and getBytes of ArrowBuf #13161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jackylee-ch wants to merge 1 commit into from
Closed

ARROW-16568: [Java] Enable skipping BOUNDS_CHECKING with setBytes and getBytes of ArrowBuf #13161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions java/memory/memory-core/src/main/java/org/apache/arrow/memory/ArrowBuf.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,12 +692,14 @@ private static boolean isOutOfBounds(long index, long length, long capacity) {
}

private void checkIndex(long index, long fieldLength) {
// check reference count
this.ensureAccessible();
// check bounds
if (isOutOfBounds(index, fieldLength, this.capacity())) {
throw new IndexOutOfBoundsException(String.format("index: %d, length: %d (expected: range(0, %d))",
index, fieldLength, this.capacity()));
if (BoundsChecking.BOUNDS_CHECKING_ENABLED) {
// check reference count
this.ensureAccessible();
// check bounds
if (isOutOfBounds(index, fieldLength, this.capacity())) {
throw new IndexOutOfBoundsException(String.format("index: %d, length: %d (expected: range(0, %d))",
index, fieldLength, this.capacity()));
}
}
}

Expand Down