Skip to content

MINOR: Fix wrongly redefining pytestmark for parquet encryption tests #13189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jorisvandenbossche merged 1 commit into from
May 18, 2022
Merged

MINOR: Fix wrongly redefining pytestmark for parquet encryption tests #13189

jorisvandenbossche merged 1 commit into from
May 18, 2022

Conversation

@raulcd
Copy link
Member

@raulcd raulcd commented May 18, 2022 •
edited
Loading

This PR should correctly skip the tests and fix the failures introduced by #13147 (comment) on the following builds:

@raulcd
Copy link
Member Author

raulcd commented May 18, 2022

@github-actions crossbow submit test-conda-python-*-pandas-latest

@github-actions
Copy link

github-actions bot commented May 18, 2022

Revision: 39bcec3

Submitted crossbow builds: ursacomputing/crossbow @ actions-2112

Task Status
test-conda-python-3.7-pandas-latest Github Actions
test-conda-python-3.8-pandas-latest Github Actions

jorisvandenbossche referenced this pull request May 18, 2022
@raulcd @jorisvandenbossche
ARROW-16548: [Python] Add pytest.mark.parquet to all tests under test…
c032290 
…s/parquet package

The implementation marks all the individual tests that are on this structure with the parquet dataset mark correctly.

Closes #13147 from raulcd/ARROW-16548

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@raulcd raulcd marked this pull request as ready for review May 18, 2022 15:23
@raulcd
Copy link
Member Author

raulcd commented May 18, 2022

@jorisvandenbossche this is now correctly skipping the tests, see the builds passing now and the tests skipped:

 opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_write_read SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_write_read_wrong_key SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_read_no_decryption_config SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_read_metadata_no_decryption_config SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_read_schema_no_decryption_config SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_write_no_col_key SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_write_kms_error SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_write_kms_specific_error SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_write_kms_factory_error SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_write_kms_factory_type_error SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_encryption_configuration SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_decryption_configuration SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_kms_configuration SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_write_read_plain_footer_single_wrapping SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_write_external SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_loop SKIPPED [ 97%]

@jorisvandenbossche jorisvandenbossche merged commit 3df2e05 into apache:master May 18, 2022
@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented May 18, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees

No one assigned

Labels

Component: Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@raulcd @jorisvandenbossche