ARROW-16592: [C++][Python][FlightRPC] Finish after failed writes #13191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently a failed write (due to the server sending an error, disconnecting, etc.) will raise an uninformative error on the client. Prior to the refactoring done in Arrow 8.0.0, this was silently swallowed (so clients would not get any indication until they finished writing). In 8.0.0 instead the error got propagated but this led to confusing, uninformative errors. Instead, tag this specific error so that the client implementation knows to finish the call and get the actual server error. (gRPC doesn't give us the actual error until we explicitly finish the call, so we can't get the actual error directly.)
cyb70289
reviewed
May 20, 2022
cyb70289
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a failed write (due to the server sending an error,
disconnecting, etc.) will raise an uninformative error on the
client. Prior to the refactoring done in Arrow 8.0.0, this was
silently swallowed (so clients would not get any indication until
they finished writing). In 8.0.0 instead the error got propagated
but this led to confusing, uninformative errors. Instead, tag this
specific error so that the client implementation knows to finish
the call and get the actual server error.
(gRPC doesn't give us the actual error until we explicitly finish
the call, so we can't get the actual error directly.)