Skip to content

ARROW-16643: [C++] Fix warnings for clang-14 #13225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wesm wants to merge 1 commit into from
Closed

ARROW-16643: [C++] Fix warnings for clang-14 #13225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cpp/cmake_modules/SetupCxxFlags.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,7 @@ if("${BUILD_WARNING_LEVEL}" STREQUAL "CHECKIN")
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wno-missing-braces")
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wno-unused-parameter")
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wno-constant-logical-operand")
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wno-return-stack-address")
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wall")
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wno-conversion")
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/arrow/flight/flight_benchmark.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ arrow::Result<std::vector<SizedBatch>> GetPutData(const perf::Token& token) {
int64_t records_sent = 0;
while (records_sent < total_records) {
if (records_sent + length > total_records) {
const int last_length = total_records - records_sent;
const int64_t last_length = total_records - records_sent;
// Hard-coded
batches.push_back(SizedBatch{batch->Slice(0, last_length),
/*bytes=*/last_length * bytes_per_record});
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/parquet/column_io_benchmark.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ void SetBytesProcessed(::benchmark::State& state, Repetition::type repetition) {
if (repetition == Repetition::REPEATED) {
bytes_processed += state.iterations() * state.range(0) * sizeof(int16_t);
}
state.SetBytesProcessed(state.iterations() * state.range(0) * sizeof(int16_t));
state.SetBytesProcessed(bytes_processed);
}

template <Repetition::type repetition,
Expand Down