Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
138 commits
Select commit Hold shift + click to select a range
b57d8c1
Move python related files into pyarrow
AlenkaF Jun 2, 2022
e276ee7
Add changes to cmake for C PyArrow
AlenkaF Jun 3, 2022
dd97026
Add cmake and build for C PyArrow to setup.py
AlenkaF Jun 3, 2022
a112790
Fix typos
AlenkaF Jun 6, 2022
f02eae2
Linter correction
AlenkaF Jun 6, 2022
b2df1d5
Change the dir from where C PyArrow is being built
AlenkaF Jun 8, 2022
fed81a6
Comment out ARROW_PYTHON from cpp/src/arrow/public_api_test.cc
AlenkaF Jun 8, 2022
62bbaab
hacky experiment
jorisvandenbossche Jun 14, 2022
23fd4c3
correct moving include files
jorisvandenbossche Jun 14, 2022
98a95fc
Make hacky experiment work for MacOS
AlenkaF Jun 15, 2022
ed2b259
Correct setup.py when pyarrow not build inplace
AlenkaF Jun 16, 2022
8ada8ee
Use a pattern to define C pyarrow library version
AlenkaF Jun 16, 2022
d2695a9
Add partial changes to python_flight build
AlenkaF Jun 22, 2022
d27e103
Correct linter and add gRPC setup for python flight
AlenkaF Jun 22, 2022
73e2011
Add more changes for python flight - still not working
AlenkaF Jun 22, 2022
fddf6ac
Add small changes to c pyarrow CMakeLists - pythin flight build now w…
AlenkaF Jun 27, 2022
d86e8cb
Handle options for Arrow and C PyArrow
AlenkaF Jun 27, 2022
865dfbd
Remove build_dist from setup.py _run_cmake()
AlenkaF Jun 27, 2022
947ac70
Try to load ArrowOptions in general with the help of ARROW_HOME env var
AlenkaF Jun 28, 2022
94f2851
Add Parquet module if PARQUET_REQUIRE_ENCRYPTION=on
AlenkaF Jun 29, 2022
1ea8e20
Build tests for C PyArrow
AlenkaF Jun 30, 2022
fe804d3
Try to fix appveyor CI error
AlenkaF Jun 30, 2022
1c3a8a1
Comments and names changes
AlenkaF Jul 1, 2022
fce199e
Remove comment for ARROW_VERSION_SCRIPT_FLAGS
AlenkaF Jul 1, 2022
7d2a55d
Change _run_cmake_cpyarrow() to _run_cmake_arrow_python()
AlenkaF Jul 1, 2022
9c3a62e
Change the use of cmake_path with file
AlenkaF Jul 1, 2022
ea45ed4
Accept ARROW_BUILD_DIR by the users to indicate build dir for Arrow C++
AlenkaF Jul 1, 2022
55887d9
Remove the need for serialization_internal.h inside python/flight.cc …
AlenkaF Jul 4, 2022
01de8e7
Remove the need for serialization_internal.h inside python/flight.cc …
AlenkaF Jul 5, 2022
51156af
Rename ARROW_CMAKE_INSTALL_DIR to ARROW_CMAKE_DIR
AlenkaF Jul 5, 2022
a9db174
Add a note for ARROW_BUILD_DIR to the python dev docs
AlenkaF Jul 5, 2022
1e51b7f
Make sure arrow/python include files do not get removed when building…
AlenkaF Jul 5, 2022
1d1d5b8
Try a fix for Could NOT find Python3 CI error
AlenkaF Jul 5, 2022
e87433d
Linter corrections
AlenkaF Jul 5, 2022
d8cbea3
Linter corrections
AlenkaF Jul 6, 2022
5e3038d
Try to fix test_gdb.py error
AlenkaF Jul 6, 2022
d11f49e
Change 'os.getcwd()' with '__path__'
AlenkaF Jul 6, 2022
b10062c
Remove path import from test_gdb.py
AlenkaF Jul 6, 2022
3075e20
Add changes to CMakeLists.txt due to errors on local Linux build
AlenkaF Jul 6, 2022
dcf5d14
String manipulation error
AlenkaF Jul 6, 2022
7993b7f
Fix Typo
AlenkaF Jul 6, 2022
248d7e1
Revert change in test_gdb.py
AlenkaF Jul 6, 2022
beec42c
Try to fix gRPC error on CI
AlenkaF Jul 7, 2022
817f377
Relax the regex in test_gdb.py to test change on the CI
AlenkaF Jul 7, 2022
a97d940
Test gdb flags
AlenkaF Jul 7, 2022
e25d3b0
Another try for gdb flags (to pass test_gdb.py)
AlenkaF Jul 7, 2022
7fba600
Remove pyarrow/include/arrow/python before copying in setup.py
AlenkaF Jul 7, 2022
cbd9aaf
Third try to set gdb flags
AlenkaF Jul 7, 2022
90eadcb
Correct a check for PYARROW_WITH_PARQUET_ENCRYPTION
AlenkaF Jul 7, 2022
122eecc
Make the gdb failing tests solution simpler with include(SetupCxxFlags)
AlenkaF Jul 7, 2022
c45754a
Revert the try change for gRPC find_package CI error
AlenkaF Jul 7, 2022
4f702b2
Revert back from using include(SetupCxxFlags) due to xsimd error on M…
AlenkaF Jul 8, 2022
9f8b1b8
Add xsmid target
AlenkaF Jul 8, 2022
3342b6f
Correct missed change from 'build' to
AlenkaF Jul 8, 2022
da788b8
Removing redundant option as ArrowOptions are now loaded
AlenkaF Jul 8, 2022
b30af60
Add a fix for conda and xsimd
AlenkaF Jul 8, 2022
f85bfb5
Another try for CI error when ARROW_GRPC_USE_SHARED=off
AlenkaF Jul 8, 2022
5ddbd84
Catch cases when ARROW_GRPC_USE_SHARED=off and ARROW_BUILD_STATIC=off…
AlenkaF Jul 8, 2022
c327b14
Do not check for conda and xsmid but check if xsmid build dir exists …
AlenkaF Jul 8, 2022
07e2e01
Rearange checks for xsimd source file
AlenkaF Jul 8, 2022
2a60b4a
Add to docs info about running ctest for C PyArrow
AlenkaF Jul 8, 2022
2d1a0b3
Add link for arrow_python_test_main
AlenkaF Jul 8, 2022
dc9b34f
One last try to fix xsimd for today ...
AlenkaF Jul 8, 2022
0eaf8e2
Simplify pyhton flight build
AlenkaF Jul 11, 2022
15b05f4
Add notes to remove xsimd and add SetupCxxFlags when ARROW-17037 is m…
AlenkaF Jul 12, 2022
dd90ec3
Add PYTHON_EXECUTABLE and Python3_EXECUTABLE to setup.py to try if it…
AlenkaF Jul 12, 2022
4c3b0f3
Try to pass AppVeyor makefile issue
AlenkaF Jul 12, 2022
348cc36
Delete replicated hacky code and add PYARROW_PARALLEL to C PyArrow build
AlenkaF Jul 12, 2022
bd0d96c
Change C pyarrow to arrow python in setup.py
AlenkaF Jul 12, 2022
703d13e
Try to use 'cmake --build' and 'cmake --install'
AlenkaF Jul 12, 2022
dedfb3e
Add check for Arrow Python tests - GTest must be bundled
AlenkaF Jul 12, 2022
0d4d555
Remove xsimd and add include(SetupCxxFlags)
AlenkaF Jul 12, 2022
0636a10
Do not use / when making paths in setup.py
AlenkaF Jul 12, 2022
eb24221
Add C PyArrow tests to CI
AlenkaF Jul 13, 2022
af2f315
Add -- for PYARROW_PARALLEL in setup.py
AlenkaF Jul 13, 2022
00d3973
Try out CI without setting ARROW_VERSION_SCRIPT_FLAGS
AlenkaF Jul 13, 2022
6d06787
Add changes to python_test.sh to check if ARROW_BUILD_TESTS=on
AlenkaF Jul 14, 2022
0ed8063
Change cmake install steps in setup.py
AlenkaF Jul 14, 2022
fc6112b
Keep arrow flight build comment from previous build procedure
AlenkaF Jul 14, 2022
accaeac
Hackish try to fix python-sdist build
AlenkaF Jul 14, 2022
c2a4ca5
Change EXIST to NOT EXIST for python-sdist build fix
AlenkaF Jul 14, 2022
b449fac
Fix typo :/
AlenkaF Jul 14, 2022
f3bc1ee
Set ARROW_PYTHON_LIB_DIR to try fix AppVeyor can't find Arrow Python …
AlenkaF Jul 15, 2022
674ef9c
Make changes to moving/copying of libs in setup.py
AlenkaF Jul 15, 2022
e04282a
Linter corrections
AlenkaF Jul 15, 2022
b9c33a0
Update setup.py again due to CI errors
AlenkaF Jul 15, 2022
e120bac
Try to copy files from /bin in setup.py
AlenkaF Jul 15, 2022
9c1e991
Fix linter errors
AlenkaF Jul 15, 2022
89f4233
Rename C PyArrow to PyArrow cpp
AlenkaF Jul 18, 2022
a78a6fb
Remove ARROW_SOURCE_DIR and rename ARROW_SOURCE to ARROW_SOURCE_DIR
AlenkaF Jul 18, 2022
f712bd5
Remove include_directories from python flight build
AlenkaF Jul 18, 2022
00e572c
Update python_test.sh
AlenkaF Jul 18, 2022
4e2635b
Apply suggestions from code review - Kou
AlenkaF Jul 18, 2022
2b4909f
Correct a follow-up link
AlenkaF Jul 18, 2022
74b69da
Add missing C PyArrow naming changes
AlenkaF Jul 18, 2022
7f70630
Rename python/pyarrow/src_arrow to python/pyarrow/src and add a strin…
AlenkaF Jul 18, 2022
764d47b
Linter corrections
AlenkaF Jul 18, 2022
da0a0cd
Correct missing changes /src_arrow to /src plus linter correction
AlenkaF Jul 18, 2022
9c537cc
Linter correction
AlenkaF Jul 18, 2022
30b424e
Add ARROW_PYTHON_VERSION to dev/release tests
AlenkaF Jul 18, 2022
55a3c90
Change selection of lib folders to be copied in _run_cmake_pyarrow_cpp
AlenkaF Jul 19, 2022
df1fb0f
Add back include_directories for python flight to fix verify-rc-sourc…
AlenkaF Jul 19, 2022
2b90050
One more missing change from Arrow Python to PyArrow CPP
AlenkaF Jul 19, 2022
fbbcb89
Add changes to try fixing ubuntu extended build failures
AlenkaF Jul 21, 2022
5834b10
Add print to check AppVeyor failure
AlenkaF Jul 21, 2022
6bd5752
Change extra missing renames for pyarrow cpp
AlenkaF Jul 21, 2022
03d545b
Changes from code review - Joris
AlenkaF Jul 21, 2022
d8fd79f
Just to test the CI remove some pytest flags for appveyor build
AlenkaF Jul 21, 2022
4b7bb71
Add tmpdir to paths for test_cython on win
AlenkaF Jul 21, 2022
4b24cf2
Linter corrections
AlenkaF Jul 21, 2022
f0ee97c
Code review suggestions - pitrou
AlenkaF Jul 21, 2022
0501d05
Add back arrow_python to move_shared_libs in setup.py
AlenkaF Jul 21, 2022
5cbdb40
Add a fix for manylinux wheels - thank you Raul
AlenkaF Jul 21, 2022
b1bdf71
Add a fix for macos wheels
AlenkaF Jul 21, 2022
1fe44a0
Skip test_cython_api on windows and investigate the fail as a follow up
AlenkaF Jul 21, 2022
c844ed9
Correct ARROW_HOME path for macos wheels
AlenkaF Jul 22, 2022
03d6347
Add a fix for windows wheels
AlenkaF Jul 24, 2022
f3ab721
Revert change in pytest for appveyor build
AlenkaF Jul 25, 2022
1fdf1ed
Test folder changed? Why didn't the CI complain :/
AlenkaF Jul 26, 2022
e495e94
Add test flags that might be missing
AlenkaF Jul 26, 2022
6272196
Ensure exactly one copy of the python lib folder is found and copied …
AlenkaF Jul 26, 2022
2d415b7
Make win libs copying separate
AlenkaF Jul 27, 2022
89bc963
Apply suggestions from code review - pitrou
AlenkaF Aug 18, 2022
bb7e870
Update arrow_python version
AlenkaF Aug 18, 2022
0a0bb0f
Remove tmpdir from the subprocess_env in test_cython_api
AlenkaF Aug 18, 2022
f755b20
Remove use_python and use_flight from arrow.spec.in
AlenkaF Aug 23, 2022
77df0bb
Remove Python related patterns from dev/tasks/tasks.yml
AlenkaF Aug 23, 2022
543caee
Remove lines that are started with @ENABLE_PYTHON@ in debian/control.in
AlenkaF Aug 23, 2022
333e757
Remove *python* in debian folder
AlenkaF Aug 23, 2022
d728969
Remove dev/tasks/linux-packages/apache-arrow/debian/*python* in rat_e…
AlenkaF Aug 23, 2022
bc0e88d
Remove python3-numpy from dev/tasks/linux-packages/apache-arrow/apt/*…
AlenkaF Aug 23, 2022
2c8de0c
Remove Python related options in debian/rules
AlenkaF Aug 23, 2022
4ce2e5b
Remove *arrow_python* from conda-recipes/arrow-cpp/meta.yaml in the a…
AlenkaF Aug 23, 2022
6ab3c6f
Remove tests from dev/release/verify-apt.sh
AlenkaF Aug 24, 2022
5219046
Correct typo in debian/rules
AlenkaF Aug 24, 2022
1cb4b39
Remove tests from dev/release/verify-apt.sh - before the test was rem…
AlenkaF Aug 24, 2022
767dda9
Remove extra python occurances in arrow.spec.in
AlenkaF Aug 25, 2022
0860306
Remove python*-devel and python*-numpy from dev/tasks/linux-packages/…
AlenkaF Aug 25, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ci/scripts/python_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
set -ex

arrow_dir=${1}
test_dir=${1}/python/build/dist

export ARROW_SOURCE_DIR=${arrow_dir}
export ARROW_TEST_DATA=${arrow_dir}/testing/data
Expand Down Expand Up @@ -54,4 +55,14 @@ export PYARROW_TEST_ORC
export PYARROW_TEST_PARQUET
export PYARROW_TEST_S3

# Testing PyArrow C++
if [ "${ARROW_BUILD_TESTS}" == "ON" ]; then
pushd ${test_dir}
ctest \
--output-on-failure \
--parallel ${n_jobs} \
--timeout 300
popd
fi
# Testing PyArrow
pytest -r s ${PYTEST_ARGS} --pyargs pyarrow
1 change: 1 addition & 0 deletions ci/scripts/python_wheel_macos_build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ export PYARROW_WITH_PLASMA=${ARROW_PLASMA}
export PYARROW_WITH_SUBSTRAIT=${ARROW_SUBSTRAIT}
export PYARROW_WITH_S3=${ARROW_S3}
export PYARROW_CMAKE_OPTIONS="-DCMAKE_OSX_ARCHITECTURES=${CMAKE_OSX_ARCHITECTURES} -DARROW_SIMD_LEVEL=${ARROW_SIMD_LEVEL}"
export ARROW_HOME=${build_dir}/install
# PyArrow build configuration
export PKG_CONFIG_PATH=/usr/lib/pkgconfig:${build_dir}/install/lib/pkgconfig
# Set PyArrow version explicitly
Expand Down
1 change: 1 addition & 0 deletions ci/scripts/python_wheel_manylinux_build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ export PYARROW_WITH_PARQUET_ENCRYPTION=${PARQUET_REQUIRE_ENCRYPTION}
export PYARROW_WITH_PLASMA=${ARROW_PLASMA}
export PYARROW_WITH_SUBSTRAIT=${ARROW_SUBSTRAIT}
export PYARROW_WITH_S3=${ARROW_S3}
export ARROW_HOME=/tmp/arrow-dist
# PyArrow build configuration
export PKG_CONFIG_PATH=/usr/lib/pkgconfig:/tmp/arrow-dist/lib/pkgconfig

Expand Down
2 changes: 1 addition & 1 deletion cpp/cmake_modules/FindArrowPython.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ find_package(Arrow ${find_package_arguments})

if(ARROW_FOUND)
arrow_find_package(ARROW_PYTHON
"${ARROW_HOME}"
"${PYARROW_CPP_HOME}"
arrow_python
arrow/python/api.h
ArrowPython
Expand Down
2 changes: 1 addition & 1 deletion cpp/cmake_modules/FindArrowPythonFlight.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ find_package(ArrowPython ${find_package_arguments})

if(ARROW_PYTHON_FOUND AND ARROW_FLIGHT_FOUND)
arrow_find_package(ARROW_PYTHON_FLIGHT
"${ARROW_HOME}"
"${PYARROW_CPP_HOME}"
arrow_python_flight
arrow/python/flight.h
ArrowPythonFlight
Expand Down
4 changes: 0 additions & 4 deletions cpp/src/arrow/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -805,10 +805,6 @@ if(ARROW_ORC)
add_subdirectory(adapters/orc)
endif()

if(ARROW_PYTHON)
add_subdirectory(python)
endif()

if(ARROW_TENSORFLOW)
add_subdirectory(adapters/tensorflow)
endif()
4 changes: 0 additions & 4 deletions cpp/src/arrow/public_api_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,6 @@
#include "arrow/json/api.h" // IWYU pragma: keep
#endif

#ifdef ARROW_PYTHON
#include "arrow/python/api.h" // IWYU pragma: keep
#endif

#ifdef DCHECK
#error "DCHECK should not be visible from Arrow public headers."
#endif
Expand Down
208 changes: 0 additions & 208 deletions cpp/src/arrow/python/CMakeLists.txt

This file was deleted.

7 changes: 7 additions & 0 deletions dev/release/01-prepare-test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,13 @@ def test_version_pre_tag
"+set(MLARROW_VERSION \"#{@release_version}\")"],
],
},
{
path: "python/pyarrow/src/CMakeLists.txt",
hunks: [
["-set(ARROW_PYTHON_VERSION \"#{@snapshot_version}\")",
"+set(ARROW_PYTHON_VERSION \"#{@release_version}\")"],
],
},
{
path: "python/setup.py",
hunks: [
Expand Down
7 changes: 7 additions & 0 deletions dev/release/post-11-bump-versions-test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,13 @@ def test_version_post_tag
"+set(MLARROW_VERSION \"#{@next_snapshot_version}\")"],
],
},
{
path: "python/pyarrow/src/CMakeLists.txt",
hunks: [
["-set(ARROW_PYTHON_VERSION \"#{@snapshot_version}\")",
"+set(ARROW_PYTHON_VERSION \"#{@next_snapshot_version}\")"],
],
},
{
path: "python/setup.py",
hunks: [
Expand Down
4 changes: 0 additions & 4 deletions dev/release/rat_exclude_files.txt
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,6 @@ dev/tasks/linux-packages/apache-arrow/debian/libarrow-glib-doc.doc-base
dev/tasks/linux-packages/apache-arrow/debian/libarrow-glib-doc.install
dev/tasks/linux-packages/apache-arrow/debian/libarrow-glib-doc.links
dev/tasks/linux-packages/apache-arrow/debian/libarrow-glib1000.install
dev/tasks/linux-packages/apache-arrow/debian/libarrow-python-dev.install
dev/tasks/linux-packages/apache-arrow/debian/libarrow-python-flight-dev.install
dev/tasks/linux-packages/apache-arrow/debian/libarrow-python-flight1000.install
dev/tasks/linux-packages/apache-arrow/debian/libarrow-python1000.install
dev/tasks/linux-packages/apache-arrow/debian/libarrow1000.install
dev/tasks/linux-packages/apache-arrow/debian/libgandiva-dev.install
dev/tasks/linux-packages/apache-arrow/debian/libgandiva-glib-dev.install
Expand Down
8 changes: 8 additions & 0 deletions dev/release/utils-prepare.sh
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,14 @@ update_versions() {
git add setup.py
popd

pushd "${ARROW_DIR}/python/pyarrow/src"
sed -i.bak -E -e \
"s/^set\(ARROW_PYTHON_VERSION \".+\"\)/set(ARROW_PYTHON_VERSION \"${version}\")/" \
CMakeLists.txt
rm -f CMakeLists.txt.bak
git add CMakeLists.txt
popd

pushd "${ARROW_DIR}/r"
sed -i.bak -E -e \
"s/^Version: .+/Version: ${r_version}/" \
Expand Down
7 changes: 0 additions & 7 deletions dev/release/verify-apt.sh
Original file line number Diff line number Diff line change
Expand Up @@ -198,13 +198,6 @@ ruby -r gi -e "p GI.load('ArrowFlightSQL')"
echo "::endgroup::"


if [ "${have_python}" = "yes" ]; then
echo "::group::Test libarrow-python"
${APT_INSTALL} libarrow-python-dev=${package_version}
echo "::endgroup::"
fi


if [ "${have_plasma}" = "yes" ]; then
echo "::group::Test Plasma"
${APT_INSTALL} libplasma-glib-dev=${package_version}
Expand Down
6 changes: 0 additions & 6 deletions dev/release/verify-yum.sh
Original file line number Diff line number Diff line change
Expand Up @@ -250,12 +250,6 @@ if [ "${have_flight}" = "yes" ]; then
echo "::endgroup::"
fi

if [ "${have_python}" = "yes" ]; then
echo "::group::Test libarrow-python"
${install_command} --enablerepo=epel arrow-python-devel-${package_version}
echo "::endgroup::"
fi

echo "::group::Test Plasma"
if [ "${have_glib}" = "yes" ]; then
${install_command} --enablerepo=epel plasma-glib-devel-${package_version}
Expand Down
Loading