ARROW-16729: [C++] Bump Abseil/gRPC dependency versions #13315
Conversation
|
|
|
@github-actions crossbow submit -g cpp |
|
Revision: b4d18d870096c707464b7f3784de864d511fa452 Submitted crossbow builds: ursacomputing/crossbow @ actions-58fae64f76
|
|
The Fedora failure appears to be because Abseil is installed systemwide, and the gRPC build is finding the system Abseil instead of the local Abseil. We're going to need some way to sneak in the bundled Abseil over the system one. |
cpp/src/arrow/flight/CMakeLists.txt
Outdated
There was a problem hiding this comment.
Hmm, do we not want to support any intermediate versions between 1.36 and 1.43, or 1.43 and 1.46?
There was a problem hiding this comment.
What happens is that if we use system gRPC, we compile the test program and then assign a version of "1.43" regardless of the actual version; if we use bundled gRPC, we derive the version number from versions.txt. So a system gRPC 1.45 would still get reported as "1.43", but since we bumped the bundled version, we need to explicitly handle it here.
cpp/src/arrow/flight/server.cc
Outdated
There was a problem hiding this comment.
Just FTR, I opened https://issues.apache.org/jira/browse/ARROW-16769 to make this easier and nicer.
There was a problem hiding this comment.
Thanks! This was just to silence a warning that I was getting
|
cc @kou for the C++ build failures |
|
@github-actions crossbow submit test-debian--cpp- |
|
Revision: bc51567f0228bde9020e9765e2fc6a963c537542 Submitted crossbow builds: ursacomputing/crossbow @ actions-66aacf6051
|
|
@github-actions crossbow submit test-fedora-35-cpp test-ubuntu-22.04-cpp |
|
Revision: a4606b69b1f69eaf3dd045f7fd80178daafc0f30 Submitted crossbow builds: ursacomputing/crossbow @ actions-835ddf315d
|
|
I think these builds were affected: https://app.travis-ci.com/github/ursacomputing/crossbow/builds/251681964 We may want to remove |
3 participants
c-ares did not need bumping.