ARROW-16788: [C++] Remove hardening flags gRPC doesn't support #13346
Conversation
|
|
|
@github-actions crossbow submit github-ubuntu-focal-amd64 travis-ubuntu-focal-arm64 |
|
|
@github-actions crossbow submit focal |
|
Revision: 66f00f3 Submitted crossbow builds: ursacomputing/crossbow @ actions-4fe9ae9e94
|
| string(REPLACE "-Wformat-security" "" GRPC_C_FLAGS "${GRPC_C_FLAGS}") | ||
| string(REPLACE "-Wformat-security" "" GRPC_CXX_FLAGS "${GRPC_CXX_FLAGS}") |
There was a problem hiding this comment.
Do we need them? I think that -Wno-format-security wins with -Wformat-security -Wno-format-security. (-Wformat-security is ignored.)
| set(GRPC_C_FLAGS | ||
| "${EP_C_FLAGS} -Wno-attributes -Wno-format-security -Wno-unknown-warning-option") | ||
| set(GRPC_CXX_FLAGS | ||
| "${EP_CXX_FLAGS} -Wno-attributes -Wno-format-security -Wno-unknown-warning-option") |
There was a problem hiding this comment.
Could you add these flags in if(NOT MSVC) ... endif()?
|
@github-actions crossbow submit ubuntu-focal-* |
| set(GRPC_CXX_FLAGS | ||
| "${EP_CXX_FLAGS} -Wno-attributes -Wno-format-security -Wno-unknown-warning-option" | ||
| ) | ||
| endif() |
There was a problem hiding this comment.
We need to initialize GRPC_C*_FLAGS for MSVC.
e.g.:
set(GRPC_C_FLAGS "${EP_C_FLAGS}")
set(GRPC_CXX_FLAGS "${EP_CXX_FLAGS}")
if(NOT MSVC)
set(GRPC_C_FLAGS "${GRPC_C_FLAGS} ...")
set(GRPC_CXX_FLAGS "${GRPC_CXX_FLAGS} ...")
endif()Or
set(GRPC_CMAKE_ARGS ...)
if(NOT MSVC)
set(GRPC_C_FLAGS "${EP_C_FLAGS} ...")
set(GRPC_CXX_FLAGS "${EP_CXX_FLAGS} ...")
list(APPEND GRPC_CMAKE_ARGS "-DCMAKE_C_FLAGS=${GRPC_C_FLAGS}" ...)
endif()There was a problem hiding this comment.
D'oh…thanks for catching that
|
Revision: 4628035 Submitted crossbow builds: ursacomputing/crossbow @ actions-98cbb695da
|
2 participants
gRPC doesn't support building with certain flags that distros insert