ARROW-16799: [C++] Create a self-pipe abstraction #13354
Conversation
Also create a FileDescriptor RAII wrapper to automate the chore of closing file descriptors, and make it more robust.
pitrou
changed the title
| return MakeArray(data); | ||
| } | ||
|
|
||
| // XXX create a testing/io.{h,cc}? |
There was a problem hiding this comment.
Did this have to be moved because of a circular dependency or something?
There was a problem hiding this comment.
No, I thought it would be better to not depend on io/ from util/, but perhaps that's not important :-)
There was a problem hiding this comment.
Ah, it does feel weird to have it in gtest_util.h, but it's already rather a grab-bag of test helpers so it's not a big deal.
|
@github-actions crossbow submit -g cpp |
|
Revision: ddd73b3 Submitted crossbow builds: ursacomputing/crossbow @ actions-177418cea1
|
|
While most CI failures are unrelated, the test-debian-10-cpp-i386 failure is directly caused by this PR. |
|
@github-actions crossbow submit -g cpp |
|
Revision: dcf1135 Submitted crossbow builds: ursacomputing/crossbow @ actions-9ec240e09d
|
3 participants
Also create a FileDescriptor RAII wrapper to automate the chore of closing file descriptors.