ARROW-1047: [Java] [FollowUp] Change ArrowMagic to be non-public class #1349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @BryanCutler |
icexelloss
changed the title
wesm
force-pushed
the
ARROW-1047-followup
branch
from
d53ff7f to
b56defb
Compare
wesm
approved these changes
Nov 23, 2017
Member
wesm
left a comment
wesm
left a comment
There was a problem hiding this comment.
+1, though ArrowMagic is only used in the file reader/writer
Member
|
I was thinking of |
Member
|
I suggest we do not merge this because the magic number is only used in the file implementation, if that's OK |
Contributor
Author
|
Yes that's good point. I will change the PR to make it ArrowMagic non public class. |
icexelloss
force-pushed
the
ARROW-1047-followup
branch
from
b56defb to
0b5df95
Compare
icexelloss
changed the title
Member
|
+1 |
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
Move ArrowMagic from vector.ipc to vector.ipc.message package. Author: Li Jin <ice.xelloss@gmail.com> Closes apache#1349 from icexelloss/ARROW-1047-followup and squashes the following commits: 0b5df95 [Li Jin] Change ArrowMagic to be non public class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move ArrowMagic from vector.ipc to vector.ipc.message package.