ARROW-17011: [C++][Flight] Remove the need for serialization_internal.h inside python/flight.cc #13546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Member
|
This should also allow to already remove the |
Member
Author
|
My bad, thanks for catching it! |
lidavidm
approved these changes
Jul 8, 2022
Member
|
Thanks for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes made to flight and python flight in #13311 are moved into this separate PR. The reason for separation is for the changes to be merged before the next release and also to make #13311 less complex.
The changes are same as in the PR mentioned. I hope that the changes in
cpp/src/arrow/python/flight.cccan serve as a test.cc @lidavidm @jorisvandenbossche