-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-16825: [Java] Rename file that contains metadata about commit git.properties #13578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… To: gitarrowinfo.properties
lidavidm
approved these changes
Jul 12, 2022
Member
lidavidm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Maybe naming nit, arrow.git.properties or something?
Member
|
This line also needs updating: Line 126 in 548aa0b
|
lidavidm
approved these changes
Jul 12, 2022
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
…it.properties (apache#13578) Rename file that contains metadata about commit: From: git.properties To: gitarrowinfo.properties Main reason: git.properties is a generic name that could be use for third party libraries for a different purpose than inspect arrow metadata information (i.e: [SpringBoot](https://docs.spring.io/spring-boot/docs/current/reference/html/application-properties.html#application-properties.core.spring.info.git.location) git.properties configuration). Current Arrow Java artifacts are using [git-commit-id-maven-plugin](https://github.com/git-commit-id/git-commit-id-maven-plugin) to generate a file `./git.properties` with commit metadata such as: ``` #Generated by Git-Commit-Id-Plugin #Wed Jun 08 11:43:58 UTC 2022 git.build.user.email= git.build.host=Mac-1654686060479.local git.dirty=true git.remote.origin.url=https\://github.com/apache/arrow git.closest.tag.name=apache-arrow-8.0.0 git.commit.id.describe-short=apache-arrow-3.0.0-3327-dirty git.commit.user.email=kou@clear-code.com git.commit.time=08.06.2022 @ 07\:51\:03 UTC git.commit.message.full=ARROW-16785\: [Packaging][Linux] Add FindThrift.cmake (\apache#13337)\n\nThis is a follow-up of ARROW-16721/\apache#13292.\n\nAuthored-by\: Sutou Kouhei <kou@clear-code.com>\nSigned-off-by\: KrisztiSz<szucs.krisztian@gmail.com> git.build.version=9.0.0.dev191 git.commit.message.short=ARROW-16785\: [Packaging][Linux] Add FindThrift.cmake (\apache#13337) git.commit.id.abbrev=5fe3a60 git.branch=5fe3a606f16b183cf706ae8d9a4adaff593c18a1 git.build.user.name= git.closest.tag.commit.count=11694 git.commit.id.describe=apache-arrow-3.0.0-3327-g5fe3a60-dirty git.commit.id=5fe3a606f16b183cf706ae8d9a4adaff593c18a1 git.tags= git.build.time=08.06.2022 @ 11\:43\:58 UTC git.commit.user.name=Sutou Kouhei ``` Artifacts affected: ``` ./plasma/target/arrow-plasma-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties ./tools/target/arrow-tools-9.0.0-SNAPSHOT-jar-with-dependencies.jar,gitarrowinfo.properties ./tools/target/arrow-tools-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties ./memory/memory-unsafe/target/arrow-memory-unsafe-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties ./memory/memory-netty/target/arrow-memory-netty-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties ./memory/memory-core/target/arrow-memory-core-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties ./dataset/target/arrow-dataset-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties ./flight/flight-sql/target/flight-sql-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties ./flight/flight-integration-tests/target/flight-integration-tests-9.0.0-SNAPSHOT-jar-with-dependencies.jar,gitarrowinfo.properties ./flight/flight-integration-tests/target/flight-integration-tests-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties ./flight/flight-grpc/target/flight-grpc-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties ./flight/flight-core/target/flight-core-9.0.0-SNAPSHOT-jar-with-dependencies.jar,gitarrowinfo.properties ./flight/flight-core/target/flight-core-9.0.0-SNAPSHOT-shaded.jar,gitarrowinfo.properties ./flight/flight-core/target/flight-core-9.0.0-SNAPSHOT-shaded-ext.jar,gitarrowinfo.properties ./flight/flight-core/target/flight-core-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties ./adapter/jdbc/target/arrow-jdbc-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties ./adapter/avro/target/arrow-avro-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties ./adapter/orc/target/arrow-orc-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties ./algorithm/target/arrow-algorithm-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties ./compression/target/arrow-compression-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties ./format/target/arrow-format-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties ./gandiva/target/arrow-gandiva-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties ./performance/target/benchmarks.jar,gitarrowinfo.properties ./performance/target/arrow-performance-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties ./vector/target/arrow-vector-9.0.0-SNAPSHOT-shade-format-flatbuffers.jar,gitarrowinfo.properties ./vector/target/arrow-vector-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties ./c/target/arrow-c-data-9.0.0-SNAPSHOT.jar,gitarrowinfo.properties ``` Authored-by: david dali susanibar arce <davi.sarces@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename file that contains metadata about commit: From: git.properties To: gitarrowinfo.properties
Main reason: git.properties is a generic name that could be use for third party libraries for a different purpose than inspect arrow metadata information (i.e: SpringBoot git.properties configuration).
Current Arrow Java artifacts are using git-commit-id-maven-plugin to generate a file
./git.propertieswith commit metadata such as:Artifacts affected: