Skip to content

Conversation

@icexelloss
Copy link
Contributor

No description provided.

@icexelloss
Copy link
Contributor Author

cc @BryanCutler

Copy link
Member

@BryanCutler BryanCutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, looks great!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this test should not have been passing...

@icexelloss
Copy link
Contributor Author

cc @siddharthteotia.

Can you also take a look please? Thanks!

@icexelloss
Copy link
Contributor Author

Thanks @BryanCutler for the review!

@wesm wesm force-pushed the remove-accessor-mutator branch from 1980147 to 3423ad4 Compare December 1, 2017 16:54
@siddharthteotia
Copy link
Contributor

+1

@wesm wesm closed this in 3ee75a0 Dec 3, 2017
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
Author: Li Jin <ice.xelloss@gmail.com>

Closes apache#1374 from icexelloss/remove-accessor-mutator and squashes the following commits:

3423ad4 [Li Jin] Remove accessor and mutator interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants