Skip to content

ARROW-9773: [C++] Implement Take kernel for ChunkedArray #13857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wjones127 wants to merge 15 commits into from
Closed

ARROW-9773: [C++] Implement Take kernel for ChunkedArray #13857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7ea173c
feat: implement dispatch for ChunkedArray take
wjones127 Jun 7, 2022
d7e7c10
Draft implementation for ChunkedPrimitiveTake
wjones127 Aug 12, 2022
e36e031
Use existing indices chunk layout
wjones127 Aug 17, 2022
a9ea85c
Reduce code duplication
wjones127 Aug 17, 2022
882ffd5
Add boolean chunked take
wjones127 Aug 17, 2022
00b9792
Partial impl
wjones127 Aug 30, 2022
0353d11
more progress
wjones127 Sep 15, 2022
173bb2a
Fix dispatch
wjones127 Sep 15, 2022
97cb201
Fix a few bugs
wjones127 Sep 15, 2022
02c23b6
Cleanup redundant classes
wjones127 Sep 16, 2022
a43fa07
fix a few bugs
wjones127 Sep 16, 2022
612862a
Prefer TakeAA over TakeCC
wjones127 Sep 19, 2022
7e5ad7a
Cleanup
wjones127 Sep 19, 2022
f7ed194
Revert most filter changes
wjones127 Sep 19, 2022
66c4780
Add chunked take benchmark
wjones127 Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/src/arrow/compute/exec_internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class ARROW_EXPORT ExecSpanIterator {
public:
ExecSpanIterator() = default;

/// \brief Initialize itertor iterator and do basic argument validation
/// \brief Initialize iterator and do basic argument validation
///
/// \param[in] batch the input ExecBatch
/// \param[in] max_chunksize the maximum length of each ExecSpan. Depending
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/arrow/compute/kernel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,7 @@ struct ScalarKernel : public Kernel {
// ----------------------------------------------------------------------
// VectorKernel (for VectorFunction)

/// \brief Kernel data structure for implementations of VectorFunction. In
/// \brief Kernel data structure for implementations of VectorFunction. It
/// contains an optional finalizer function, the null handling and memory
/// pre-allocation preferences (which have different defaults from
/// ScalarKernel), and some other execution-related options.
Expand Down
Loading