ARROW-17405: [Doc][Java] C Data Interface library able to compile with mvn command #13881
Conversation
| Maven | ||
| ~~~~~ | ||
|
|
||
| - To build only the C Data Interface library: |
There was a problem hiding this comment.
If we itemize this subsection, we need to indent the following .. code-block:: to put into this subsection.
|
These changes look ok to me. Is the Java Windows failure random/intermittent or is there something that needed fixing there? |
|
Could you rebase on the master? |
Merged with master |
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
+1
We can merge this after we sort lists.
| -DCMAKE_BUILD_TYPE=Release \ | ||
| -DCMAKE_INSTALL_PREFIX=java-dist/lib \ | ||
| -DARROW_JAVA_JNI_ENABLE_DEFAULT=OFF \ | ||
| -DARROW_JAVA_JNI_ENABLE_C=ON \ | ||
| -DBUILD_TESTING=OFF |
There was a problem hiding this comment.
Could you sort this list in alphabetical order?
| -DARROW_DEPENDENCY_USE_SHARED=OFF\ | ||
| -DARROW_CSV=ON \ | ||
| -DARROW_DATASET=ON \ | ||
| -DARROW_FILESYSTEM=ON \ | ||
| -DARROW_GANDIVA=ON \ | ||
| -DARROW_GANDIVA_JAVA=ON \ | ||
| -DARROW_GANDIVA_STATIC_LIBSTDCPP=ON \ | ||
| -DARROW_JNI=ON \ | ||
| -DARROW_ORC=ON \ | ||
| -DARROW_PARQUET=ON \ | ||
| -DARROW_PLASMA=ON \ | ||
| -DARROW_PLASMA_JAVA_CLIENT=ON \ | ||
| -DARROW_S3=ON \ | ||
| -DARROW_USE_CCACHE=ON \ | ||
| -DCMAKE_BUILD_TYPE=Release \ | ||
| -DCMAKE_INSTALL_LIBDIR=lib \ | ||
| -DCMAKE_INSTALL_PREFIX=java-dist \ | ||
| -DCMAKE_UNITY_BUILD=ON \ | ||
| -DARROW_DEPENDENCY_SOURCE=BUNDLED |
There was a problem hiding this comment.
Could you sort this list in alphabetical order?
| -DCMAKE_BUILD_TYPE=Release \ | ||
| -DCMAKE_INSTALL_PREFIX=java-dist/lib \ | ||
| -DCMAKE_PREFIX_PATH=$PWD/java-dist \ | ||
| -DARROW_JAVA_JNI_ENABLE_DEFAULT=OFF \ | ||
| -DARROW_JAVA_JNI_ENABLE_DATASET=ON \ | ||
| -DBUILD_TESTING=OFF |
There was a problem hiding this comment.
Could you sort this list in alphabetical order?
java/pom.xml
Outdated
| -DCMAKE_BUILD_TYPE=Release | ||
| -DCMAKE_INSTALL_PREFIX=${arrow.c.jni.dist.dir} | ||
| -DARROW_JAVA_JNI_ENABLE_DEFAULT=OFF | ||
| -DARROW_JAVA_JNI_ENABLE_C=ON | ||
| -DBUILD_TESTING=OFF |
There was a problem hiding this comment.
Could you sort this list in alphabetical order?
|
Benchmark runs are scheduled for baseline = 78bfecf and contender = f57e1ba. f57e1ba is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…h mvn command (apache#13881) C Data Interface library (.so / .dylib) able to compile with mvn command: $ mvn clean generate-resources -Pgenerate-cdata-dylib_so -N Authored-by: david dali susanibar arce <davi.sarces@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…h mvn command (apache#13881) C Data Interface library (.so / .dylib) able to compile with mvn command: $ mvn clean generate-resources -Pgenerate-cdata-dylib_so -N Authored-by: david dali susanibar arce <davi.sarces@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
4 participants
C Data Interface library (.so / .dylib) able to compile with mvn command:
$ mvn clean generate-resources -Pgenerate-cdata-dylib_so -N