Skip to content

ARROW-17388: [C++][Python] Error on WriteTable if duplicate field names #13938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
milesgranger wants to merge 2 commits into from
Closed

ARROW-17388: [C++][Python] Error on WriteTable if duplicate field names #13938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb218b6
Prevent Fields with same name in Schema
milesgranger Aug 22, 2022
ee88edc
Error on WriteTable if duplicate field names
milesgranger Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions cpp/src/parquet/arrow/writer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,15 @@ class FileWriterImpl : public FileWriter {
chunk_size = this->properties().max_row_group_length();
}

// Cannot write with duplicate field names
std::unordered_set<std::string> s;
for (auto field : table.fields()) {
if (s.count(field->name()) > 0) {
return Status::Invalid("Cannot write parquet table with duplicate field names: ", field->name());
}
s.insert(field->name());
}

auto WriteRowGroup = [&](int64_t offset, int64_t size) {
RETURN_NOT_OK(NewRowGroup(size));
for (int i = 0; i < table.num_columns(); i++) {
Expand Down
11 changes: 11 additions & 0 deletions python/pyarrow/tests/test_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4182,6 +4182,17 @@ def file_visitor(written_file):
assert pathlib.Path(visited_path) in expected_paths


def test_write_table_duplicate_fields(tempdir):
table = pa.table([
pa.array(range(5)),
pa.array(range(5)),
], names=['a', 'a'])

match = "Cannot write parquet table with duplicate field names: a"
with pytest.raises(pa.ArrowInvalid, match=match):
pq.write_table(table, tempdir / 'file.parquet')


def test_write_table_multiple_fragments(tempdir):
table = pa.table([
pa.array(range(10)), pa.array(np.random.randn(10)),
Expand Down