ARROW-1867: [Java] Add missing methods to BitVector from legacy vector class #1396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
siddharthteotia
approved these changes
Dec 6, 2017
Contributor
|
LGTM. Thanks @BryanCutler ! |
icexelloss
approved these changes
Dec 6, 2017
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
…r class After the ValueVector refactor, the BitVector class was missing the methods setToOne and setRangeToOne from the legacy vector class. This PR adds them back and restores the BItVector tests to use these APIs. Author: Bryan Cutler <cutlerb@gmail.com> Closes apache#1396 from BryanCutler/java-addmissing-BitVector-methods-ARROW-1867 and squashes the following commits: 1614216 [Bryan Cutler] added methods setToOne and setRangeToOne from legacy BitVector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the ValueVector refactor, the BitVector class was missing the methods setToOne and setRangeToOne from the legacy vector class. This PR adds them back and restores the BItVector tests to use these APIs.