Skip to content

ARROW-17079: Show HTTP status code for unknown S3 errors #14019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitrou merged 9 commits into from
Sep 6, 2022
Merged

ARROW-17079: Show HTTP status code for unknown S3 errors #14019

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
792a5b1
Show http status codes for S3 errors
pcmoritz Sep 1, 2022
b93cebe
Update s3_internal.h
pcmoritz Sep 1, 2022
2a664ca
update
pcmoritz Sep 5, 2022
247f6cf
fix
pcmoritz Sep 5, 2022
fbce231
fix
pcmoritz Sep 5, 2022
4cd8d6d
fixes and lint
pcmoritz Sep 5, 2022
f2f9322
lint
pcmoritz Sep 5, 2022
4b3837d
use stringstream
pcmoritz Sep 5, 2022
5d2c2e6
Capitalize HTTP
pitrou Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions cpp/src/arrow/filesystem/s3_internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,10 +152,14 @@ Status ErrorToStatus(const std::string& prefix, const std::string& operation,
// XXX Handle fine-grained error types
// See
// https://sdk.amazonaws.com/cpp/api/LATEST/namespace_aws_1_1_s3.html#ae3f82f8132b619b6e91c88a9f1bde371
return Status::IOError(
prefix, "AWS Error ",
S3ErrorToString(static_cast<Aws::S3::S3Errors>(error.GetErrorType())), " during ",
operation, " operation: ", error.GetMessage());
auto error_type = static_cast<Aws::S3::S3Errors>(error.GetErrorType());
std::stringstream ss;
ss << S3ErrorToString(error_type);
if (error_type == Aws::S3::S3Errors::UNKNOWN) {
ss << " (HTTP status " << static_cast<int>(error.GetResponseCode()) << ")";
}
return Status::IOError(prefix, "AWS Error ", ss.str(), " during ", operation,
" operation: ", error.GetMessage());
}

template <typename ErrorType, typename... Args>
Expand Down