ARROW-17519: [R] RTools35 job is failing #14035
Conversation
|
|
nealrichardson
left a comment
nealrichardson
left a comment
There was a problem hiding this comment.
If we're going to fully drop support, there's a bit more to remove here, including:
- logic in ci/scripts/PKGBUILD and ci/scripts/r_windows_build.sh
- Anything involving
on_old_windows() - README/vignette updating
There probably are other workarounds in r/src that could be removed too.
| `NOT_CRAN=true`. See `vignette("install", package = "arrow")` for | ||
| details. | ||
|
|
||
| For Windows users of R 3.6 and earlier, note that support for AWS S3 is not |
There was a problem hiding this comment.
This should probably say that 9.0.0 is the last version that supports Windows R < 4.0, and also note that feature set is limited on those older R version builds.
ci/scripts/PKGBUILD
Outdated
| # Without this, some compute functionality segfaults in tests | ||
| export CMAKE_UNITY_BUILD=OFF | ||
| fi | ||
| export ARROW_GCS=ON |
There was a problem hiding this comment.
These don't need to be defined out here anymore, they can just be set in the cmake below like the other flags. If you want them configurable, you can set them like `-DARROW_GCS="${ARROW_GCS:-ON}" like we do in inst/build_arrow_static.sh.
|
(I'll re-run the Windows checks tonight when there's less CI pressure so that the Windows job doesn't keep timing out...) |
|
These CI failures don't seem to be related - the DuckDB failure is ARROW-17643. I don't know what the integration test failure is related to but the error message doesn't seem to be related R. |
|
Benchmark runs are scheduled for baseline = ff3aa3b and contender = c586b9f. c586b9f is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
This PR removes the RTools35 CI job as it's currently failing and we're about to drop support following the vote to move to C++17. Authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
3 participants
This PR removes the RTools35 CI job as it's currently failing and we're about to drop support following the vote to move to C++17.